Ovirt devel - Jan 2009 - [PATCH node] Remove code that allowed ovirtbr0 to show up.

Our method for naming bridges is to prepend "ovirtbr" to the name of
the
physical interface. This patch removes the previous practice of removing
the first 3 letters from the interface name.

Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
---
 scripts/ovirt-early |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/ovirt-early b/scripts/ovirt-early
index 8422893..b098ba1 100755
--- a/scripts/ovirt-early
+++ b/scripts/ovirt-early
@@ -61,7 +61,7 @@ configure_from_network() {
     # bridge each ethernet device in the system
     ETHDEVS=$(cd /sys/class/net && ls -d eth*)
     for eth in $ETHDEVS; do
-        BRIDGE=ovirtbr`echo $eth | cut -b4-`
+        BRIDGE=ovirtbr$eth
         log "Applying default configuration to $eth and $BRIDGE"
         printf '%s\n' "DEVICE=$eth" ONBOOT=yes
"BRIDGE=$BRIDGE" \
             > /etc/sysconfig/network-scripts/ifcfg-$eth
-- 
1.6.0.6

Darryl L. Pierce wrote:
> Our method for naming bridges is to prepend "ovirtbr" to the name
of the
> physical interface. This patch removes the previous practice of removing
> the first 3 letters from the interface name.
> 
> Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
> ---
>  scripts/ovirt-early |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/ovirt-early b/scripts/ovirt-early
> index 8422893..b098ba1 100755
> --- a/scripts/ovirt-early
> +++ b/scripts/ovirt-early
> @@ -61,7 +61,7 @@ configure_from_network() {
>      # bridge each ethernet device in the system
>      ETHDEVS=$(cd /sys/class/net && ls -d eth*)
>      for eth in $ETHDEVS; do
> -        BRIDGE=ovirtbr`echo $eth | cut -b4-`
> +        BRIDGE=ovirtbr$eth
>          log "Applying default configuration to $eth and $BRIDGE"
>          printf '%s\n' "DEVICE=$eth" ONBOOT=yes
"BRIDGE=$BRIDGE" \
>              > /etc/sysconfig/network-scripts/ifcfg-$eth
looks good to me, ack

-- 
|=-        Red Hat, Engineering, Emerging Technologies, Boston        -=|
|=-                     Email: pmyers at redhat.com                      -=|
|=-         Office: +1 412 474 3552   Mobile: +1 703 362 9622         -=|
|=- GnuPG: E65E4F3D 88F9 F1C9 C2F3 1303 01FE 817C C5D2 8B91 E65E 4F3D -=|

On Wed, Jan 21, 2009 at 02:34:05PM -0500, Darryl L. Pierce
wrote:
> Our method for naming bridges is to prepend "ovirtbr" to the name
of the
> physical interface. This patch removes the previous practice of removing
> the first 3 letters from the interface name.
I've always wondered why we bother to include 'ovirt' in the bridge
name at all. Far nicer just to call them  br0, br1, br2, or if you
want the main nic name,  breth0, breth1, breth2

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|