Sorry about that, let me check the correct version for the intrin0.h include guard. //Marcus ________________________________ From: Ralph Giles <giles at thaumas.net> Sent: Thursday, June 11, 2020 19:31 To: Marcus Asteborg <xnorpx at outlook.com>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches Speaking of needing more complete ci feedback, the intrin0.h patch broke the appveyor build:> Microsoft (R) Build Engine version 14.0.25420.1 > [...] > :\projects\opus\celt\ecintrin.h(53): fatal error C1083: Cannot openinclude file: 'intrin0.h': No such file or directory [C:\projects\opus\win32\VS2015\opus.vcxproj] https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Frillian%2Fopus%2Fbuilds%2F33474422&data=02%7C01%7C%7C4162e72343444c9c310608d80e78ad01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637275258756998152&sdata=1zMyaftA7NjAXL52YRlQtwyNG3Xaen2U7kngJ%2F8KZtU%3D&reserved=0 Is this an extra feature the appveyor environment doesn't apply, or is the version guard incorrect? -r On Mon, 2020-06-08 at 05:39 +0000, Marcus Asteborg wrote:> Hi, > > Here are 3 suggested patches. > Build test for cmake and run the test in gitlab-ci. > Disable the message box on Windows on abort that cause test hangs in > CI. > Build time improvement by removing unnecessary includes of stdio.h in > production code and change to a lighter header intrin.h -> intrin0.h > (windows only). Attached screenshot of measurement but it resulted in > 14% buildspeed compared to master on Windows 64 debug builds on my > setup. As most improvements comes from change intrin.h the impact on > other platforms will not be that much. > //Marcus > _______________________________________________ > opus mailing list > opus at xiph.org > https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C4162e72343444c9c310608d80e78ad01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637275258757008148&sdata=wrR6%2FwZJoaV%2F7s36m3MglWx41ntOa3ZGXRwQh%2BU7cDU%3D&reserved=0-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20200612/d563174e/attachment.html>
Verified that intrin0.h was available in 1910, by building it locally on VS2017 version 15.0 MSVC++ 14.1 _MSC_VER == 1910 (Visual Studio 2017 version 15.0) https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B //Marcus ________________________________ From: Marcus Asteborg <xnorpx at outlook.com> Sent: Thursday, June 11, 2020 20:15 To: Ralph Giles <giles at thaumas.net>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches Sorry about that, let me check the correct version for the intrin0.h include guard. //Marcus ________________________________ From: Ralph Giles <giles at thaumas.net> Sent: Thursday, June 11, 2020 19:31 To: Marcus Asteborg <xnorpx at outlook.com>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches Speaking of needing more complete ci feedback, the intrin0.h patch broke the appveyor build:> Microsoft (R) Build Engine version 14.0.25420.1 > [...] > :\projects\opus\celt\ecintrin.h(53): fatal error C1083: Cannot openinclude file: 'intrin0.h': No such file or directory [C:\projects\opus\win32\VS2015\opus.vcxproj] https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Frillian%2Fopus%2Fbuilds%2F33474422&data=02%7C01%7C%7C4162e72343444c9c310608d80e78ad01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637275258756998152&sdata=1zMyaftA7NjAXL52YRlQtwyNG3Xaen2U7kngJ%2F8KZtU%3D&reserved=0 Is this an extra feature the appveyor environment doesn't apply, or is the version guard incorrect? -r On Mon, 2020-06-08 at 05:39 +0000, Marcus Asteborg wrote:> Hi, > > Here are 3 suggested patches. > Build test for cmake and run the test in gitlab-ci. > Disable the message box on Windows on abort that cause test hangs in > CI. > Build time improvement by removing unnecessary includes of stdio.h in > production code and change to a lighter header intrin.h -> intrin0.h > (windows only). Attached screenshot of measurement but it resulted in > 14% buildspeed compared to master on Windows 64 debug builds on my > setup. As most improvements comes from change intrin.h the impact on > other platforms will not be that much. > //Marcus > _______________________________________________ > opus mailing list > opus at xiph.org > https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C4162e72343444c9c310608d80e78ad01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637275258757008148&sdata=wrR6%2FwZJoaV%2F7s36m3MglWx41ntOa3ZGXRwQh%2BU7cDU%3D&reserved=0-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20200612/7f586786/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Use-correct-_MSC_VER-for-intrin0.h.patch Type: application/octet-stream Size: 800 bytes Desc: 0001-Use-correct-_MSC_VER-for-intrin0.h.patch URL: <http://lists.xiph.org/pipermail/opus/attachments/20200612/7f586786/attachment-0001.obj>
Thanks. I've pushed https://gitlab.xiph.org/xiph/opus/-/merge_requests/8 to verify. -r On Fri, 2020-06-12 at 04:00 +0000, Marcus Asteborg wrote:> Verified that intrin0.h was available in 1910, by building it locally > on VS2017 version 15.0 > > MSVC++ 14.1 _MSC_VER == 1910 (Visual Studio 2017 version 15.0) > > https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B > > //Marcus > From: Marcus Asteborg <xnorpx at outlook.com> > Sent: Thursday, June 11, 2020 20:15 > To: Ralph Giles <giles at thaumas.net>; opus at xiph.org <opus at xiph.org> > Subject: Re: [opus] Misc patches > > Sorry about that, let me check the correct version for the intrin0.h > include guard. > > //Marcus > From: Ralph Giles <giles at thaumas.net> > Sent: Thursday, June 11, 2020 19:31 > To: Marcus Asteborg <xnorpx at outlook.com>; opus at xiph.org < > opus at xiph.org> > Subject: Re: [opus] Misc patches > > Speaking of needing more complete ci feedback, the intrin0.h patch > broke the appveyor build: > > > Microsoft (R) Build Engine version 14.0.25420.1 > > [...] > > :\projects\opus\celt\ecintrin.h(53): fatal error C1083: Cannot open > include file: 'intrin0.h': No such file or directory > [C:\projects\opus\win32\VS2015\opus.vcxproj] > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Frillian%2Fopus%2Fbuilds%2F33474422&data=02%7C01%7C%7C4162e72343444c9c310608d80e78ad01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637275258756998152&sdata=1zMyaftA7NjAXL52YRlQtwyNG3Xaen2U7kngJ%2F8KZtU%3D&reserved=0 > > Is this an extra feature the appveyor environment doesn't apply, or > is > the version guard incorrect? > > -r > > On Mon, 2020-06-08 at 05:39 +0000, Marcus Asteborg wrote: > > Hi, > > > > Here are 3 suggested patches. > > Build test for cmake and run the test in gitlab-ci. > > Disable the message box on Windows on abort that cause test hangs > in > > CI. > > Build time improvement by removing unnecessary includes of stdio.h > in > > production code and change to a lighter header intrin.h -> > intrin0.h > > (windows only). Attached screenshot of measurement but it resulted > in > > 14% buildspeed compared to master on Windows 64 debug builds on my > > setup. As most improvements comes from change intrin.h the impact > on > > other platforms will not be that much. > > //Marcus > > _______________________________________________ > > opus mailing list > > opus at xiph.org > > > https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.xiph.org%2Fmailman%2Flistinfo%2Fopus&data=02%7C01%7C%7C4162e72343444c9c310608d80e78ad01%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637275258757008148&sdata=wrR6%2FwZJoaV%2F7s36m3MglWx41ntOa3ZGXRwQh%2BU7cDU%3D&reserved=0 >