Felicia Lim
2017-Mar-24 20:58 UTC
[opus] [PATCH] Fix OPUS_ARG_NONNULL indices in opus_multistream.h
Hi all, The attached patch adds/fixes a few null argument checks in the multistream API. Do these changes make sense? Thanks, Felicia -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170324/1afee1e1/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Fix-OPUS_ARG_NONNULL-indices-in-opus_multistream.h.patch Type: text/x-patch Size: 1284 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/opus/attachments/20170324/1afee1e1/attachment.bin>
Mark Harris
2017-Mar-25 18:21 UTC
[opus] [PATCH] Fix OPUS_ARG_NONNULL indices in opus_multistream.h
On Fri, Mar 24, 2017 at 1:58 PM, Felicia Lim <flim at google.com> wrote:> Hi all, > > The attached patch adds/fixes a few null argument checks in the multistream > API. Do these changes make sense?This looks good except that I think the 5th argument should remain NONNULL on line 276. - Mark
Felicia Lim
2017-Mar-27 17:46 UTC
[opus] [PATCH] Fix OPUS_ARG_NONNULL indices in opus_multistream.h
Thanks for spotting that, Mark. I've fixed it and merged in master. On Sat, Mar 25, 2017 at 11:21 AM Mark Harris <mark.hsj at gmail.com> wrote:> On Fri, Mar 24, 2017 at 1:58 PM, Felicia Lim <flim at google.com> wrote: > > Hi all, > > > > The attached patch adds/fixes a few null argument checks in the > multistream > > API. Do these changes make sense? > > This looks good except that I think the 5th argument should remain > NONNULL on line 276. > > - Mark >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170327/b776c2ec/attachment.html>