opus - May 2009 - A (minor) bug and a request

Cheers all.

I believe that the first line in the function FLOAT2INT16 in celt.c 
which is now:

x = x*32768.;

should be:

x = SCALEIN(x);

This only makes a difference if you change the SCALEIN and SCALEOUT 
macros (which I do).

The new feature I would like to request is the addition of a 
CELT_RESET_STATE control for both the encoder and decoder. I cache 
encoder and decoder instances and would like to be able to reset them to 
a newly minted state when I change streams.

Thanx,

John Ridges

Hi John,

John Ridges a ?crit :
> I believe that the first line in the function FLOAT2INT16 in celt.c 
> which is now:
> x = x*32768.;
> should be:
> x = SCALEIN(x);
> This only makes a difference if you change the SCALEIN and SCALEOUT 
> macros (which I do).
OK, will make sure it's the right thing (appears to be) and fix that.
Just curious, what value do you use and why?
> The new feature I would like to request is the addition of a 
> CELT_RESET_STATE control for both the encoder and decoder. I cache 
> encoder and decoder instances and would like to be able to reset them to 
> a newly minted state when I change streams.
Yes, this has been on the TODO list for a while (unfortunately not on
top). You (or anyone else) can speed that up by sending a patch.

Cheers,

	Jean-Marc