On Wed, 16 Feb 2022, Corinna Vinschen wrote:> So the sk certs fail if builddir != srcdir, independent of the target.Ah, good catch. It's probably not finding regress/misc/sk-dummy.so. I can't recreate this on Debian, but I think (thanks to Darren) that I have a RHish VM around somewhere and I'll try to reproduce it on that. -d
On Thu, 17 Feb 2022 at 12:36, Damien Miller <djm at mindrot.org> wrote:> > On Wed, 16 Feb 2022, Corinna Vinschen wrote: > > > So the sk certs fail if builddir != srcdir, independent of the target. > > Ah, good catch.I second that, nice find!> It's probably not finding regress/misc/sk-dummy.so. > I can't recreate this on Debian, but I think (thanks to Darren) that > I have a RHish VM around somewhere and I'll try to reproduce it on > that.Try starting from a clean checkout. My guess is that a previous test run left something (maybe sk-dummy.so) in the top-level directory. I'm using Fedora 34, but I rarely start from a clean dir. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.
On Thu, 17 Feb 2022, Damien Miller wrote:> On Wed, 16 Feb 2022, Corinna Vinschen wrote: > > > So the sk certs fail if builddir != srcdir, independent of the target. > > Ah, good catch. It's probably not finding regress/misc/sk-dummy.so. > I can't recreate this on Debian, but I think (thanks to Darren) that > I have a RHish VM around somewhere and I'll try to reproduce it on > that.I was able to recreate this on Rocky Linux, this seems to fix it: diff --git a/regress/test-exec.sh b/regress/test-exec.sh index 15bdd0847..358d8082e 100644 --- a/regress/test-exec.sh +++ b/regress/test-exec.sh @@ -576,6 +576,8 @@ elif [ -f "${SRC}/misc/sk-dummy/obj/sk-dummy.so" ] ; then SSH_SK_PROVIDER="${SRC}/misc/sk-dummy/obj/sk-dummy.so" elif [ -f "${SRC}/misc/sk-dummy/sk-dummy.so" ] ; then SSH_SK_PROVIDER="${SRC}/misc/sk-dummy/sk-dummy.so" +elif [ -f "${OBJ}/misc/sk-dummy/sk-dummy.so" ] ; then + SSH_SK_PROVIDER="${OBJ}/misc/sk-dummy/sk-dummy.so" fi export SSH_SK_PROVIDER (I tried just s/SRC/OBJ/ in the second else case, but that breaks Debian)