openssh unix dev - Jun 2017 - [patch] Fix incoming compression statistics

Hello,

somewhere between 6.7 and 7.4, the compression statistics shown when
running the client with -C -v got messed up. For the incoming
compression, the numbers for outgoing are used, reversed.

This got reported in https://bugs.debian.org/797964 but appearently
was never forwarded upstream. Trivial patch below, kudos to Russell Coker.

    Christoph

--- openssh-7.2p2.orig/packet.c
+++ openssh-7.2p2/packet.c
@@ -525,7 +525,7 @@ ssh_packet_close(struct ssh *ssh)
 				deflateEnd(stream);
 		}
 		if (state->compression_in_started) {
-			z_streamp stream = &state->compression_out_stream;
+			z_streamp stream = &state->compression_in_stream;
 			debug("compress incoming: "
 			    "raw data %llu, compressed %llu, factor %.2f",
 			    (unsigned long long)stream->total_out,

On Mon, Jun 5, 2017 at 9:30 PM, Christoph Biedl
<debian.axhn at manchmal.in-ulm.de> wrote:
> somewhere between 6.7 and 7.4, the compression statistics shown when
> running the client with -C -v got messed up.
For the record it was in OpenBSD's rev 1.201 which corresponds to v6.8.
> For the incoming
> compression, the numbers for outgoing are used, reversed.
Patch applied, thanks.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.