On 2015-06-01 1:06 AM, Darren Tucker wrote:> You were running the tests as root? I think we need to add > PermitRootLogin=yes to the regression tests to cover this case.I filed a bug report (https://bugzilla.mindrot.org/show_bug.cgi?id=2412), prematurely perhaps (i.e., I hope not a duplicate) - and doing a su to michael helped the tests along - a lot. In the end some of the tests fail because AIX diff does not support the -u option. I shall rerun tomorrow with gnu diff installed. As I never use sudo - how is "make tests" expected to work on pristine system? Or will sudo just default to letting everyone become root so "rootlike" things can be tested? (This is why for builds I test as root - so applications can verify they drop "super" powers. Please note: that this build that is passing tests is the same build process (less one argument --without-openssl). So, I am hoping you will be able to get "make tests" working (on AIX) in time for 6.9p1. (and I requested the https://bugzilla.mindrot.org/show_bug.cgi?id=2370 be reopened - or do you prefer a new one as the "symptom" has changed. * I have not forgotten it is 'experimental' - but I would love to be able to try it in production! Details are at https://bugzilla.mindrot.org/show_bug.cgi?id=2412
On Sun, 7 Jun 2015, aixtools wrote:> On 2015-06-01 1:06 AM, Darren Tucker wrote: > > You were running the tests as root? I think we need to add > > PermitRootLogin=yes to the regression tests to cover this case. > I filed a bug report (https://bugzilla.mindrot.org/show_bug.cgi?id=2412), > prematurely perhaps (i.e., I hope not a duplicate) - and doing a su to michael > helped the tests along - a lot. > > In the end some of the tests fail because AIX diff does not support the -u > option. I shall rerun tomorrow with gnu diff installed.I think we should just remove -u from our diff calls - we've already done this for other tests.> As I never use sudo - how is "make tests" expected to work on pristine > system? Or will sudo just default to letting everyone become root so > "rootlike" things can be tested? (This is why for builds I test as > root - so applications can verify they drop "super" powers.It expects that sudo can be run with any command and root as a target user. -d
On 2015-06-07 5:13 AM, Damien Miller wrote:> On Sun, 7 Jun 2015, aixtools wrote: > >> On 2015-06-01 1:06 AM, Darren Tucker wrote: >>> You were running the tests as root? I think we need to add >>> PermitRootLogin=yes to the regression tests to cover this case. >> I filed a bug report (https://bugzilla.mindrot.org/show_bug.cgi?id=2412), >> prematurely perhaps (i.e., I hope not a duplicate) - and doing a su to michael >> helped the tests along - a lot. >> >> In the end some of the tests fail because AIX diff does not support the -u >> option. I shall rerun tomorrow with gnu diff installed. > I think we should just remove -u from our diff calls - we've already > done this for other tests. > >> As I never use sudo - how is "make tests" expected to work on pristine >> system? Or will sudo just default to letting everyone become root so >> "rootlike" things can be tested? (This is why for builds I test as >> root - so applications can verify they drop "super" powers. > It expects that sudo can be run with any command and root as a target > user. > > -dIn any case, after adding gnu.diffutils - all tests passed (except for those skipped, re: SUDO) And - I'll repeat here. Willing to provide 'whatever is needed' to addin AIX RBAC support. Will need help to get it integrated though.