openssh unix dev - Apr 2002 - [Bug 230] UsePrivilegeSeparation turns off Banner.

http://bugzilla.mindrot.org/show_bug.cgi?id=230





------- Additional Comments From krh at lemniscate.net  2002-04-29 10:53 -------
I should add that I also have PrintMotd off so that the motd is
printed only once, and yes, I am connecting with the SSH 2 protocol.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=230





------- Additional Comments From stevesk at pobox.com  2002-04-30 01:51 -------
currently, with privsep on, the banner file needs to be in /var/empty.  so
if your banner is /etc/issue, you need /var/empty/etc/issue.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=230





------- Additional Comments From djm at mindrot.org  2002-04-30 11:46 -------
Created an attachment (id=91)
Make Banner work with privsep as expected




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=230





------- Additional Comments From djm at mindrot.org  2002-04-30 11:47 -------
Could you please try the attached patch?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=230





------- Additional Comments From provos at citi.umich.edu  2002-04-30 12:14
-------
That diff looks good to me.  I can not test right now, but it is the
right approach.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=230





------- Additional Comments From krh at lemniscate.net  2002-05-01 17:52 -------
The patch does not apply cleanly to any snapshot between April 27 and
April 30.  Applying it by hand doesn't help, because whether or not I
do that, the compile fails with:

readpassphrase.c: In function `handler':
readpassphrase.c:183: `signo' undeclared (first use in this function)
readpassphrase.c:183: (Each undeclared identifier is reported only once
readpassphrase.c:183: for each function it appears in.)
readpassphrase.c: At top level:
readpassphrase.c:181: warning: `handler' defined but not used



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=230





------- Additional Comments From djm at mindrot.org  2002-05-01 22:02 -------
Thanks - the fix for that will be in the next snapshot. If you are impatient,
you can edit openbsd-compat/readpassphrase.c and move the "#endif"
from below
the readpassphase() function (~line 168) to the end of the file.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=230

krh at lemniscate.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From krh at lemniscate.net  2002-05-02 14:41 -------
Well, to get the May 1 snapshot to compile, I had to edit config.h
and manually undefine HAVE_READPASSPHRASE, and I had to edit readpass.c
and include openbsd-compat/readpassphrase.h.  Otherwise the compile
fails at readpass.c:101 with RPP_ECHO_{ON,OFF} and RPP_REQUIRE_TTY
undefined.

But once I did that (and I'm sure it's not the Right Thing, because
sshd didn't recognize the keywords KerberosAuthentication and
AFSTokenPassing in sshd_config), everything compiled and Banner
worked with UsePrivilegeSeparation.  Thanks!



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=230

djm at mindrot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From djm at mindrot.org  2002-05-02 16:19 -------
I'll reopen the bug until the fix gets committed. Could you please file a
seperate bug for the readpassphrase problem?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=230

djm at mindrot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From djm at mindrot.org  2002-05-13 11:02 -------
Patch committed



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.