openssh bugs - Jan 2023 - [Bug 3520] New: autoreconf is overkill for a fresh checkout

https://bugzilla.mindrot.org/show_bug.cgi?id=3520

            Bug ID: 3520
           Summary: autoreconf is overkill for a fresh checkout
           Product: Portable OpenSSH
           Version: 9.1p1
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: Build system
          Assignee: unassigned-bugs at mindrot.org
          Reporter: sparr0 at gmail.com

This may not be worth worrying about, but it may also be useful to add
as a note in INSTALL. After a fresh git checkout, I am able to compile
after `aclocal && autoconf`, which is a subset of what `autoreconf`
does and requires fewer additional tools to be available.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3520

--- Comment #1 from Clarence "Sparr" Risher <sparr0 at
gmail.com> ---
I may have spoken too soon. I did some other processes while
troubleshooting another problem and may have manually run one or more
of the other autoreconf steps outside of my efforts here.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3520

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net

--- Comment #2 from Darren Tucker <dtucker at dtucker.net> ---
(In reply to Clarence "Sparr" Risher from comment
#0)
> This may not be worth worrying about, but it may also be useful to
> add as a note in INSTALL. After a fresh git checkout, I am able to
> compile after `aclocal && autoconf`, which is a subset of what
> `autoreconf` does and requires fewer additional tools to be
> available.
That's not sufficient, you also need "autoheader":

$ git clone https://github.com/openssh/openssh-portable && cd
openssh-portable && aclocal && autoconf && ./configure
[...]
config.status: error: cannot find input file: `config.h.in'

$ autoheader && ./configure && make
[...]
$ ./ssh -V
OpenSSH_9.1p1, OpenSSL 3.0.5 5 Jul 2022

but given that this only impacts people building the development
versions, and that it's possible to do the autoconf prep on a machine
other than the build target (that's what our VM-based tests do since it
keeps the prereqs on the VMs to a minimum) I'd rather specify the thing
that guaranteed to do all of the needful even if that means you may
have to install another package or two on the development machine.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3520

Sam James <sam at gentoo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo.org

--- Comment #3 from Sam James <sam at gentoo.org> ---
This seems like premature optimisation anyway. It also depends on
future changes to the build system and then someone may well forget to
update INSTALL.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3520

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #4 from Darren Tucker <dtucker at dtucker.net> ---
(In reply to Sam James from comment #3)
> This seems like premature optimisation anyway. It also depends on
> future changes to the build system and then someone may well forget
> to update INSTALL.
Agreed, I'm happy with the existing instructions.

Clarence: thanks  for the report, but we don't plan on changing this.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3520

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
OpenSSH 9.3 has been released. Close resolved bugs

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.