openssh bugs - Apr 2021 - [Bug 3301] New: ssh-copy-id to Solaris 10 or older

https://bugzilla.mindrot.org/show_bug.cgi?id=3301

            Bug ID: 3301
           Summary: ssh-copy-id to Solaris 10 or older
           Product: Portable OpenSSH
           Version: 8.5p1
          Hardware: Other
                OS: Windows 10
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh-copy-id
          Assignee: unassigned-bugs at mindrot.org
          Reporter: carlos.rodriguez-gili at upc.edu

Solaris 10 and older Solaris' /bin/sh is not POSIX.
Using ssh-copy-id fails with the following error:

    sh: test: argument expected

The problem can be solved using double quotes for test -z in the
INSTALLKEYS_SH heredoc:

    - { [ -z \`tail -1c ${AUTH_KEY_FILE} 2>/dev/null\` ] ||
    + { [ -z "\`tail -1c ${AUTH_KEY_FILE} 2>/dev/null\`" ] ||

The resulting script seems to work for non-existing, empty, and
populated ~/.ssh/authorized_keys files. I don't see the double quotes
breaking POSIX (although unnecessary).

I don't think this is a big issue, just thought you might like to know.

BTW it also happens with older versions (before installkeys_sh()).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3301

Jakub Jelen <jjelen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jjelen at redhat.com

--- Comment #1 from Jakub Jelen <jjelen at redhat.com> ---
Please, fill this as a MR to https://gitlab.com/phil_hands/ssh-copy-id

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3301

--- Comment #2 from Carlos Rodr?guez-Gili <carlos.rodriguez-gili at
upc.edu> ---
DONE

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3301

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |djm at mindrot.org
         Resolution|---                         |MOVED

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3301

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
closing bugs resolved before openssh-8.9

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.