bugzilla-daemon at mindrot.org
2021-Apr-08 01:48 UTC
[Bug 3293] New: Check if MAX is already defined in memmem.c
https://bugzilla.mindrot.org/show_bug.cgi?id=3293
Bug ID: 3293
Summary: Check if MAX is already defined in memmem.c
Product: Portable OpenSSH
Version: 8.5p1
Hardware: Other
OS: Windows 10
Status: NEW
Severity: enhancement
Priority: P5
Component: Build system
Assignee: unassigned-bugs at mindrot.org
Reporter: balu.gajjala at gmail.com
defines.h already defined MAX, MIN. It first checks if MAX is not
defined.
In memmem.c, it's assumed MAX is not defined and we define one more
time.
https://github.com/openssh/openssh-portable/blob/d1bd184046bc310c405f45da3614a1dc5b3e521a/defines.h#L487
https://github.com/openssh/openssh-portable/blob/d1bd184046bc310c405f45da3614a1dc5b3e521a/openbsd-compat/memmem.c#L64
--
You are receiving this mail because:
You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2021-Apr-08 01:48 UTC
[Bug 3293] Check if MAX is already defined in memmem.c
https://bugzilla.mindrot.org/show_bug.cgi?id=3293
balu <balu.gajjala at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |balu.gajjala at gmail.com
--
You are receiving this mail because:
You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2021-Apr-08 01:49 UTC
[Bug 3293] Check if MAX is already defined in memmem.c
https://bugzilla.mindrot.org/show_bug.cgi?id=3293
balu <balu.gajjala at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2021-Apr-08 03:36 UTC
[Bug 3293] Check if MAX is already defined in memmem.c
https://bugzilla.mindrot.org/show_bug.cgi?id=3293
Darren Tucker <dtucker at dtucker.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
CC| |dtucker at dtucker.net
Status|NEW |RESOLVED
Blocks| |3270
--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
Fixed, thanks for the report.
Referenced Bugs:
https://bugzilla.mindrot.org/show_bug.cgi?id=3270
[Bug 3270] Tracking bug for 8.6 release
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at mindrot.org
2021-Apr-23 04:57 UTC
[Bug 3293] Check if MAX is already defined in memmem.c
https://bugzilla.mindrot.org/show_bug.cgi?id=3293
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #2 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.