bugzilla-daemon at mindrot.org
2021-Jan-04 11:51 UTC
[Bug 3248] New: SFTP can not sort files by modification time
https://bugzilla.mindrot.org/show_bug.cgi?id=3248
Bug ID: 3248
Summary: SFTP can not sort files by modification time
Product: Portable OpenSSH
Version: 8.4p1
Hardware: Other
OS: Linux
Status: NEW
Severity: enhancement
Priority: P5
Component: sftp
Assignee: unassigned-bugs at mindrot.org
Reporter: jjelen at redhat.com
Created attachment 3463
--> https://bugzilla.mindrot.org/attachment.cgi?id=3463&action=edit
proposed patch from Red Hat Bug
Originally reported as Red Hat Bug with patch:
https://bugzilla.redhat.com/show_bug.cgi?id=1909988
When sorting files based on the modification time from remote glob in
the client SFTP, the return values from sglob_comp() is wrong (1 or 0
and 0 or -1 with -r flag) causing the files are incorrectly sorted
inside of the qsort, which expects -1, 0 or 1. For more information,
see the analysis in the above bug.
--
You are receiving this mail because:
You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2021-Jan-08 02:39 UTC
[Bug 3248] SFTP can not sort files by modification time
https://bugzilla.mindrot.org/show_bug.cgi?id=3248
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3463|0 |1
is obsolete| |
Status|NEW |ASSIGNED
CC| |djm at mindrot.org
Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 3464
--> https://bugzilla.mindrot.org/attachment.cgi?id=3464&action=edit
tweaked patch
I think it also needs to handle the == case.
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at mindrot.org
2021-Jan-08 02:45 UTC
[Bug 3248] SFTP can not sort files by modification time
https://bugzilla.mindrot.org/show_bug.cgi?id=3248
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |3217
--- Comment #2 from Damien Miller <djm at mindrot.org> ---
fix committed and will be in OpenSSH 8.5
Referenced Bugs:
https://bugzilla.mindrot.org/show_bug.cgi?id=3217
[Bug 3217] Tracking bug for 8.5 release
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2021-Jan-08 11:13 UTC
[Bug 3248] SFTP can not sort files by modification time
https://bugzilla.mindrot.org/show_bug.cgi?id=3248 --- Comment #3 from Jakub Jelen <jjelen at redhat.com> --- (In reply to Damien Miller from comment #1)> Created attachment 3464 [details] > tweaked patch > > I think it also needs to handle the == case.Thank you. Indeed, the equal is a corner case but your patch looks fine. -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at mindrot.org
2021-Jan-10 01:45 UTC
[Bug 3248] SFTP can not sort files by modification time
https://bugzilla.mindrot.org/show_bug.cgi?id=3248
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at mindrot.org
2021-Apr-23 05:10 UTC
[Bug 3248] SFTP can not sort files by modification time
https://bugzilla.mindrot.org/show_bug.cgi?id=3248
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #4 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.