openssh bugs - Oct 2018 - [Bug 2921] New: fix compilation --with-ssl-engine

https://bugzilla.mindrot.org/show_bug.cgi?id=2921

            Bug ID: 2921
           Summary: fix compilation --with-ssl-engine
           Product: Portable OpenSSH
           Version: -current
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Miscellaneous
          Assignee: unassigned-bugs at mindrot.org
          Reporter: cote2004-github at yahoo.com

Created attachment 3194
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3194&action=edit
fix OPENSSL_VERSION number in openssl-compat.c

openssl version number is wrong in openbsd-compat/openssl-compat.c, 
ssh_OpenSSL_add_all_algorithms(void)

The result is that compilation fails with openssl < 1.1.0:

openssl-compat.c: In function 'ssh_OpenSSL_add_all_algorithms':
openssl-compat.c:82:2: warning: implicit declaration of function
'OPENSSL_init_crypto'; did you mean 'OPENSSL_init'?
[-Wimplicit-function-declaration]
  OPENSSL_init_crypto(OPENSSL_INIT_ADD_ALL_CIPHERS |
  ^~~~~~~~~~~~~~~~~~~
  OPENSSL_init
openssl-compat.c:82:22: error: 'OPENSSL_INIT_ADD_ALL_CIPHERS'
undeclared (first use in this function); did you mean
'OPENSSL_NO_WEAK_SSL_CIPHERS'?
  OPENSSL_init_crypto(OPENSSL_INIT_ADD_ALL_CIPHERS |
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
                      OPENSSL_NO_WEAK_SSL_CIPHERS

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2921

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Status|NEW                         |RESOLVED
             Blocks|                            |2915
         Resolution|---                         |FIXED

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
ugh.

Thanks. I've applied this patch to the master and V_7_9 branches.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2915
[Bug 2915] Tracking bug for 8.0 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2921

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |openssh at davidnewall.com

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
*** Bug 2931 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2921

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jbrown at easypost.com

--- Comment #3 from Darren Tucker <dtucker at dtucker.net> ---
*** Bug 2979 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2921

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Close bugs fixed in openssh-8.1 release cycle

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2921

Ahmed Sayeed <ahmedsayeed1982 at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmedsayeed1982 at yahoo.com

--- Comment #5 from Ahmed Sayeed <ahmedsayeed1982 at yahoo.com> ---
$ cat test.c
        struct foo {
            int len; https://www.webb-dev.co.uk/category/computers/
            int items[];
        };

        struct foo *p;
    http://www.compilatori.com/category/technology/
        int main() {
            return 0;
        }
        $ gcc test.c -g -O0 -o test
http://www.acpirateradio.co.uk/category/computers/
        $ ./gdb -q -nx --data-directory=data-directory ./test -ex
'python
gdb.parse_and_eval("p").type.target()["items"].type.range()'
        Reading symbols from ./test...
http://www-look-4.com/category/computers/
        /home/simark/src/binutils-gdb/gdb/gdbtypes.h:435:
internal-error: LONGEST dynamic_prop::const_val() const: Assertion
`m_kind == PROP_CONST' failed.
        A problem internal to GDB has been detected,
        further debugging may prove unreliable.
        Quit this debugging session? (y or n)
http://www.logoarts.co.uk/category/computers/

    This is because the Python code (typy_range) blindly reads the high
    bound of the type of `items` as a constant value.  Since it is a
http://www.iu-bloomington.com/category/computers/
    flexible array member, it has no high bound, the property is
undefined.
    Since commit 8c2e4e0689
https://komiya-dental.com/category/computers/ ("gdb: add accessors to
struct dynamic_prop"),
    the getters check that you are not getting a property value of the
wrong
    kind, so this causes a failed assertion.
http://www.slipstone.co.uk/category/computers/

    Fix it by checking if the property is indeed a constant value
before http://embermanchester.uk/category/computers/
    accessing it as such.  Otherwise, use 0.  This restores the
previous GDB
    behavior: because the structure was zero-initialized,
http://connstr.net/category/computers/  this is what was
    returned before.  But now this behavior is explicit and not
accidental.
    http://joerg.li/category/computers/
    Add a test, gdb.python/flexible-array-member.exp, that is derived
from
    gdb.base/flexible-array-member.exp.
http://www.jopspeech.com/category/computers/  It tests the same things,
but
    through the Python API.  It also specifically tests getting the
range
    from the various kinds
http://www.wearelondonmade.com/category/computers/ of flexible array
member types (AFAIK it wasn't
    possible to do the equivalent through the CLI).
https://waytowhatsnext.com/category/computers/

    gdb/ChangeLog:

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.