openssh bugs - Jan 2018 - [Bug 2818] New: Atari FreeMiNT platform needs patch to openbsd-compat

https://bugzilla.mindrot.org/show_bug.cgi?id=2818

            Bug ID: 2818
           Summary: Atari FreeMiNT platform needs patch to openbsd-compat
           Product: Portable OpenSSH
           Version: 7.6p1
          Hardware: 68k
                OS: Other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Miscellaneous
          Assignee: unassigned-bugs at mindrot.org
          Reporter: alanh at fairlite.co.uk

Created attachment 3112
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3112&action=edit
FreeMiNT patch

Attached.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2818

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
Comment on attachment 3112
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3112
FreeMiNT patch

I don't follow what this is fixing.  It has <sys/statvfs.h> but not
statvfs() ?  Could you please show the relevant #defines from config.h
on this platform?

Also m68k seriously?  How long does a login take?
> 	/* as defined in IEEE Std 1003.1, 2004 Edition */
>+#if ((!defined(HAVE_STATVFS) && defined(HAVE_STATFS)) || \
>+     (!defined(HAVE_FSTATVFS) && defined(HAVE_FSTATFS)))
> struct statvfs {
If you need to conditionalize this struct I think configure should
explicitly check for it, not try to infer it from other definitions.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2818

--- Comment #2 from Alan Hourihane <alanh at fairlite.co.uk> ---
This is a 68060 running at 100MHz, and it's pretty fast. Login is a
second.

Excerpts from the config.h are here...

/* #undef HAVE_FSTATFS */
/* #undef HAVE_FSTATVFS */
/* #undef HAVE_PSTAT */
#define HAVE_STATFS 1
#define HAVE_STATVFS 1
#define HAVE_STRUCT_STAT_ST_BLKSIZE 1
#define HAVE_STRUCT_STAT_ST_MTIM 1
#define HAVE_STRUCT_STAT_ST_MTIME 1
/* #undef HAVE_SYS_PSTAT_H */
#define HAVE_SYS_STATVFS_H 1
#define HAVE_SYS_STAT_H 1

I don't think conditionalizing it in configure.ac would be any benefit.
The tests that are already in execution do what's necessary.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.