bugzilla-daemon at mindrot.org
2015-Mar-27 15:20 UTC
[Bug 2373] New: memory leak in sshd.c:2262
https://bugzilla.mindrot.org/show_bug.cgi?id=2373 Bug ID: 2373 Summary: memory leak in sshd.c:2262 Product: Portable OpenSSH Version: 6.7p1 Hardware: Other OS: Linux Status: NEW Severity: trivial Priority: P5 Component: sshd Assignee: unassigned-bugs at mindrot.org Reporter: jjelen at redhat.com Created attachment 2577 --> https://bugzilla.mindrot.org/attachment.cgi?id=2577&action=edit patch During some playing around with openss-6.8 I found one memory leak in server. This was introduced in https://anongit.mindrot.org/openssh.git/commit/?id=5ecb41629860687b145be63b8877fabb6bae5eda It happened that you are not freeing allocated string with local_ipaddr. This is nothing critical, but nice to have. Patch is quite simple (see attachment). -- You are receiving this mail because: You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2015-Apr-15 05:36 UTC
[Bug 2373] memory leak in sshd.c:2262
https://bugzilla.mindrot.org/show_bug.cgi?id=2373 --- Comment #1 from Darren Tucker <dtucker at zip.com.au> --- Comment on attachment 2577 --> https://bugzilla.mindrot.org/attachment.cgi?id=2577 patch>- get_local_ipaddr(sock_in), get_local_port()); >+ (addr = get_local_ipaddr(sock_in)), get_local_port());I think it'd be cleaner to do that assignment on a separate line rather than buried in the format string args.>+ xfree(addr);What version did you test this against? xfree() is long gone. -- You are receiving this mail because: You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2015-Apr-15 05:37 UTC
[Bug 2373] memory leak in sshd.c:2262
https://bugzilla.mindrot.org/show_bug.cgi?id=2373 Darren Tucker <dtucker at zip.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2360 CC| |dtucker at zip.com.au -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at mindrot.org
2015-Apr-15 07:23 UTC
[Bug 2373] memory leak in sshd.c:2262
https://bugzilla.mindrot.org/show_bug.cgi?id=2373 Jakub Jelen <jjelen at redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2577|0 |1 is obsolete| | --- Comment #2 from Jakub Jelen <jjelen at redhat.com> --- Created attachment 2586 --> https://bugzilla.mindrot.org/attachment.cgi?id=2586&action=edit revised patch Thanks for comments. I was fixing this in recently released 6.8, but I don't know why I posted here xfree. Probably slow switching of context from fixing similar issue in older versions. Adding revised patch with morning insight. -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at mindrot.org
2015-Apr-15 23:24 UTC
[Bug 2373] memory leak in sshd.c:2262
https://bugzilla.mindrot.org/show_bug.cgi?id=2373 Darren Tucker <dtucker at zip.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Darren Tucker <dtucker at zip.com.au> --- I just committed a slightly modified version of this patch and it'll be in the 6.9 release. Thanks. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2015-Aug-11 13:02 UTC
[Bug 2373] memory leak in sshd.c:2262
https://bugzilla.mindrot.org/show_bug.cgi?id=2373 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Damien Miller <djm at mindrot.org> --- Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.