openssh bugs - Oct 2014 - [Bug 2300] New: reexec.sh and login-timeout.sh fail due to a race condition

https://bugzilla.mindrot.org/show_bug.cgi?id=2300

            Bug ID: 2300
           Summary: reexec.sh and login-timeout.sh  fail due to  a race
                    condition
           Product: Portable OpenSSH
           Version: 6.7p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Regression tests
          Assignee: unassigned-bugs at mindrot.org
          Reporter: plautrba at redhat.com

Created attachment 2499
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2499&action=edit
fix race condition between kill sshd and start_sshd

run test reexec.sh ...
test config passing
FATAL: no sshd running on port 4242
Makefile:168: recipe for target 't-exec' failed
make[1]: *** [t-exec] Error 1
make[1]: Leaving directory
'/home/plautrba/devel/src/bachradsusi.github/openssh-portable.git/regress'
Makefile:483: recipe for target 'tests' failed
make: *** [tests] Error 2

The problem is in the race between

$SUDO kill `$SUDO cat $PIDFILE`

and following

start_sshd

While sshd is still runnning and closing opened socket after it got a
signal, the test tries to run a new sshd instance which cannot bind to
not-yet-released socket. The attached patch tries to fix it.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2300

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
the tests have had a stop_sshd function that waits for sshd to actually
exit since 2016.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.