openssh bugs - Jul 2014 - [Bug 2257] New: ssh - Connection closed by UNKNOWN

https://bugzilla.mindrot.org/show_bug.cgi?id=2257

            Bug ID: 2257
           Summary: ssh - Connection closed by UNKNOWN
           Product: Portable OpenSSH
           Version: 6.6p1
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: plautrba at redhat.com

ssh clients shows "closed by UNKNOWN" message when a socket is closed
by a
remote side while ssh is waiting for user's password:

$ ssh user at localhost
user at localhost's password:
Connection closed by UNKNOWN

When the packet_read_seqnr() calls get_remote_ipaddr(), a connection's
socket is already closed and there's not been any other call of this
function
yet so canonical_host_ip from canohost.c is still NULL and the function
returns "UNKNOWN". I think that it could be workarounded by calling
get_remote_ipaddr() right
after packet_set_connection(), e.g. using another debug message, or
there could be set_remote_ipaddr() in canonhost.c for that.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2257

--- Comment #1 from Petr Lautrbach <plautrba at redhat.com> ---
Created attachment 2457
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2457&action=edit
add set_remote_ipaddr()

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2257

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2457|0                           |1
        is obsolete|                            |
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
                 CC|                            |djm at mindrot.org,
                   |                            |dtucker at zip.com.au
             Status|NEW                         |ASSIGNED
   Attachment #2611|                            |ok?(dtucker at zip.com.au)
              Flags|                            |

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Created attachment 2611
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2611&action=edit
improve ECONNRESET error message

On -current, just tweaking the error seems sufficient.

$ ./ssh/obj/ssh -p 2222 127.0.0.1                                
djm at 127.0.0.1's password: 
Connection reset by 127.0.0.1

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2257

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2611|0                           |1
        is obsolete|                            |
   Attachment #2611|ok?(dtucker at zip.com.au)     |
              Flags|                            |
   Attachment #2612|                            |ok?(dtucker at zip.com.au)
              Flags|                            |

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Created attachment 2612
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2612&action=edit
improved diff; refactor to sshpkt_fatal

I just noticed there is already sshpkt_fatal() for this purpose

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2257

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2612|ok?(dtucker at zip.com.au)     |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2257

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
patch applied - this will be in openssh-6.9

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2257

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.