openssh bugs - Oct 2013 - [Bug 2159] New: Implement SSH2_FXF_APPEND

https://bugzilla.mindrot.org/show_bug.cgi?id=2159

            Bug ID: 2159
           Summary: Implement SSH2_FXF_APPEND
           Product: Portable OpenSSH
           Version: 6.2p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: sftp-server
          Assignee: unassigned-bugs at mindrot.org
          Reporter: rosslagerwall at gmail.com

Created attachment 2353
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2353&action=edit
Patch to implement the feature

Hi,

I submitted this a few weeks ago to the mailing list but got no
response so I resent it and am putting it here so it doesn't get lost.

This patch implements SSH2_FXF_APPEND in the sftp server.  It is a
fairly trivial patch and applies against the proper OpenSSH and the
Portable edition.  I would argue that it is important for OpenSSH to
implement SSH2_FXF_APPEND since it is in the spec and clients who
expect
it to work find that their files are overwritten rather than appended
to.

Some relevant links:
http://marc.info/?l=openssh-unix-dev&m=138053388830753&w=2
http://marc.info/?l=openssh-unix-dev&m=123798287811788
http://marc.info/?l=openssh-unix-dev&m=111093206900604
https://bugzilla.gnome.org/show_bug.cgi?id=608910

Thanks

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2159

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Status|NEW                         |ASSIGNED
             Blocks|                            |2130

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
looks reasonable.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2159

Ross Lagerwall <rosslagerwall at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Ross Lagerwall <rosslagerwall at gmail.com> ---
As far as I can tell this has been commited.

Closing as fixed.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2159

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
No, this hasn't been committed yet. Please don't close the bug until it
is.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2159

--- Comment #4 from Ross Lagerwall <rosslagerwall at gmail.com> ---
(In reply to Damien Miller from comment #3)
> No, this hasn't been committed yet. Please don't close the bug
until
> it is.
Sorry. I thought it was committed because it seems to have committed in
revision 101 over here:
http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/sftp-server.c.diff?r1=1.100;r2=1.101

The commit message for that seems to be unrelated though:
"""
refactor client config code a little:

add multistate option partsing to readconf.c, similar to servconf.c's
existing code.

move checking of options that accept "none" as an argument to
readconf.c

add a lowercase() function and use it instead of explicit tolower() in
loops

part of a larger diff that was ok markus@
"""

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2159

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
ha, you're correct. I'd sent the patch out for review, but must have
forgotten it was in my tree when committing something unrelated.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2159

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.