openssh bugs - Feb 2012 - [Bug 1980] New: use updated ssh-copy-id

https://bugzilla.mindrot.org/show_bug.cgi?id=1980

             Bug #: 1980
           Summary: use updated ssh-copy-id
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 5.9p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Miscellaneous
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: phil at hands.com


As you can see here:

  http://git.hands.com/ssh-copy-id

and as mentioned here:

 
http://lists.mindrot.org/pipermail/openssh-unix-dev/2010-December/029123.html

I've produced an updated version of ssh-copy-id

I hope you don't consider that I'm being pushy by also submitting a
bug, but the mail to the list provoked no response whatsoever, and it
seems a shame that this is not getting used upstream.

I note that there are probably bug reports that have been reported
against the old version, that may well also apply to this (i.e. I just
noticed the bug report about SELinux incompatibility).  I'll cheerfully
fix such issues if they are shown to exist, but I'm unlikely to put the
work in unless there's some reasonable prospect of the work being put
to use.

Cheers, Phil.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1980

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> 2012-02-24
11:30:50 EST ---
Created attachment 2133
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2133
patch showing differences from current

A bug is our preferred method of getting our attention since we don't
always (often?) have spare cycles :-)

I've attached the diff comparing the two for reviewing purposes.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1980

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> 2012-02-24
11:50:27 EST ---
Comment on attachment 2133
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2133
patch showing differences from current

It's a big diff so it's hard to evaluate it.  some random comments:
> USER_HOST=${1%:}
is that a bashism?  it doesn't work with solaris' /bin/sh
>but it is much better to instead use
>+.Xr ssh 1 Ns 's
>+.Ar ProxyCommand
>+option with
>+.Xr netcat 1
you can use ssh -W insted of ssh+netcat as a proxycommand which behaves
the same but doesn't require anything on the intermediate host except
tcp port forwarding.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1980

--- Comment #3 from Philip Hands <phil at hands.com> 2012-02-25 10:35:52
EST ---
[Hmm, seems bugzilla ignored my reply, so I'll paste it in here]

 > https://bugzilla.mindrot.org/show_bug.cgi?id=1980
 > 
 > --- Comment #2 from Darren Tucker <dtucker at zip.com.au> 2012-02-24
11:50:27 EST ---
 [ 2 more citation lines. Click/Enter to show. ]
 > Comment on attachment 2133
 >   --> https://bugzilla.mindrot.org/attachment.cgi?id=2133
 > patch showing differences from current
 > 
 > It's a big diff so it's hard to evaluate it.

 Well, it's more an almost complete rewrite that a diff, so perhaps
 better to evaluate it from that point of view.

 >  some random comments:
 > 
 > > USER_HOST=${1%:}
 > 
 > is that a bashism?  it doesn't work with solaris' /bin/sh

 Really?  It works in dash, so how out of date is solaris's version of
posix?

 =-=-=-=-
 phil at poker:~/src/ssh-copy-id$ dash
 $ X=foo:
 $ echo $X
 foo:
 $ echo ${X%:}
 foo
 $ 
 =-=-=-=-

 So, any suggestions for a portable implementation (given that I'd
rather
 assumed that if dash does it, most other shell implementations would
be
 capable too, but apparently not -- of course I've been writing shell
 stuff since the early '80s so it's a little difficult to remember what
 counts as obsolete these days).

 > >but it is much better to instead use
 > >+.Xr ssh 1 Ns 's
 [ 4 more citation lines. Click/Enter to show. ]
 > >+.Ar ProxyCommand
 > >+option with
 > >+.Xr netcat 1
 > 
 > you can use ssh -W insted of ssh+netcat as a proxycommand which
behaves
 > the same but doesn't require anything on the intermediate host
except
 > tcp port forwarding.

 Ah, good point, I'd not noticed that option, but that nicely
side-steps
 the problem with there being two nc implementations with varying
options,
 so I'll definitely be using that in future -- thanks.

 Cheers, Phil.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1980

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au

--- Comment #4 from Darren Tucker <dtucker at zip.com.au> 2012-03-09
10:38:21 EST ---
(In reply to comment #3)
>  Really?  It works in dash, so how out of date is solaris's version of
> posix?
Sadly, Solaris isn't even the usual lowest common denominator (that
honour usually goes to one of the SCOs unixes).

It looks like I did the equivalent with sed:
http://anoncvs.mindrot.org/index.cgi/openssh/contrib/ssh-copy-id?r1=1.9&r2=1.10

It'd probably be worth checking if any of the other changes in our
history apply to your version.
http://anoncvs.mindrot.org/index.cgi/openssh/contrib/ssh-copy-id?view=log

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.