openssh bugs - Jan 2012 - [Bug 1968] New: openssh won't build with --with-audit=bsm on Solaris 11

https://bugzilla.mindrot.org/show_bug.cgi?id=1968

             Bug #: 1968
           Summary: openssh won't build with --with-audit=bsm on Solaris
                    11
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 5.9p1
          Platform: ix86
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Miscellaneous
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: magnus.johansson at foxt.com


When doing ./configure --with-audit=bsm the build fails on Solaris 11.
Apparently
(https://forums.oracle.com/forums/thread.jspa?threadID=2150559) the BSM
API has changed between Solaris 10 and 11. The error also occurs when I
try openssh-SNAP-20120103. Below is the exact error:

./configure --with-audit=bsm
[snip]
make
[snip]
gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare
-Wformat-security -Wno-pointer-sign -Wno-unused-result
-fno-strict-aliasing -fno-builtin-memset -fstack-protector-all -I. -I. 
-DSSHDIR=\"/usr/local/etc\" 
-D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\"
 -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\" 
-D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" 
-D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" 
-D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" 
-D_PATH_SSH_PIDDIR=\"/var/run\" 
-D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c
audit-bsm.c
audit-bsm.c: In function ?selected?:
audit-bsm.c:178:3: warning: implicit declaration of function ?getacna?
audit-bsm.c: In function ?bsm_audit_record?:
audit-bsm.c:216:2: error: too few arguments to function ?au_close?
/usr/include/bsm/libbsm.h:119:12: note: declared here
audit-bsm.c: In function ?bsm_audit_bad_login?:
audit-bsm.c:258:15: error: ?BSM_TEXTBUFSZ? undeclared (first use in
this function)
audit-bsm.c:258:15: note: each undeclared identifier is reported only
once for each function it appears in
audit-bsm.c:258:7: warning: unused variable ?textbuf?
audit-bsm.c: In function ?audit_event?:
audit-bsm.c:322:18: error: ?BSM_TEXTBUFSZ? undeclared (first use in
this function)
audit-bsm.c:322:10: warning: unused variable ?textbuf?
*** Error code 1
make: Fatal error: Command failed for target `audit-bsm.o'

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1968

--- Comment #1 from Magnus Johansson <magnus.johansson at foxt.com>
2012-02-06 19:25:08 EST ---
Created attachment 2126
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2126
Patch to make openssh build on Solaris 11.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1968

--- Comment #2 from Magnus Johansson <magnus.johansson at foxt.com>
2012-02-06 19:25:47 EST ---
Created attachment 2127
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2127
Patch to make openssh build on Solaris 11.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1968

--- Comment #3 from Magnus Johansson <magnus.johansson at foxt.com>
2012-02-06 19:28:13 EST ---
I just attached two patches to make openssh build on Solaris 11. The
main problem was that the getacna function was removed from Solaris 11.
This patch adds a reimplementation of it that uses SMF instead of the
obsoleted config-file.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1968

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au

--- Comment #4 from Darren Tucker <dtucker at zip.com.au> 2012-02-24
10:23:51 EST ---
patches look reasonable although I can't test them.  It'd be nice if
configure detected the lack or presence of the missing bits (so that
future versions work too) but I'm ok with committing it as to solve the
immediate problem.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1968

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1930
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Darren Tucker <dtucker at zip.com.au> 2012-02-24
10:41:24 EST ---
Patch committed, it will be in the 6.0p1 release.

Thanks.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.