bugzilla-daemon at bugzilla.mindrot.org
2011-Jul-30 17:51 UTC
[Bug 1921] New: [Patch] memory leak in sftp-client.c
https://bugzilla.mindrot.org/show_bug.cgi?id=1921
Bug #: 1921
Summary: [Patch] memory leak in sftp-client.c
Classification: Unclassified
Product: Portable OpenSSH
Version: -current
Platform: All
OS/Version: All
Status: NEW
Severity: trivial
Priority: P2
Component: sftp
AssignedTo: unassigned-bugs at mindrot.org
ReportedBy: loganaden at gmail.com
Created attachment 2071
--> https://bugzilla.mindrot.org/attachment.cgi?id=2071
Fix for memory leak in sftp-client.c
in do_hardlink(), buffer_init(&msg) may be unfreed
if the server does not support hardlink condition is met.
Jonathan Armani (armani@) advises moving it down.
Same thing happens in do_readlink(): if it's unable
to readlink(), the function returns without freeing
msg.
I've attached a patch. This runs on both openbsd -current
& portable openssh -current.
The attached patch concerns portable OpenSSH.
Thanks & Regards,
//Logan
C-x-C-c
--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2011-Jul-30 19:42 UTC
[Bug 1921] [Patch] memory leak in sftp-client.c
https://bugzilla.mindrot.org/show_bug.cgi?id=1921
Ajay R Ramjatan <ajay.ramjatan at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ajay.ramjatan at gmail.com
--- Comment #1 from Ajay R Ramjatan <ajay.ramjatan at gmail.com>
2011-07-31 05:42:22 EST ---
Patches, compiles and works on Linux x86, gcc 4.5.2
OpenSSH_5.8p2, OpenSSL 1.0.0d 8 Feb 2011
--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2011-Jul-30 19:50 UTC
[Bug 1921] [Patch] memory leak in sftp-client.c
https://bugzilla.mindrot.org/show_bug.cgi?id=1921 --- Comment #2 from Loganaden Velvindron <loganaden at gmail.com> 2011-07-31 05:50:21 EST --- (In reply to comment #0)> Created attachment 2071 [details] > Fix for memory leak in sftp-client.c > > in do_hardlink(), buffer_init(&msg) may be unfreed > if the server does not support hardlink condition is met. > > Jonathan Armani (armani@) advises moving it down. > > Same thing happens in do_readlink(): if it's unable > to readlink(), the function returns without freeing > msg. > > I've attached a patch. This runs on both openbsd -current > & portable openssh -current. > > The attached patch concerns portable OpenSSH. > > Thanks & Regards, > //Logan > C-x-C-cMy mistake. I sent another patch for OpenSSH on openbsd. http://marc.info/?l=openbsd-tech&m=131131952504707&w=2 -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2011-Sep-22 11:56 UTC
[Bug 1921] [Patch] memory leak in sftp-client.c
https://bugzilla.mindrot.org/show_bug.cgi?id=1921
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |djm at mindrot.org
Blocks| |1930
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Damien Miller <djm at mindrot.org> 2011-09-22 21:56:55
EST ---
Markus applied these, they will be in OpenSSH-6.0
--
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.