bugzilla-daemon at bugzilla.mindrot.org
2011-Jul-05 16:10 UTC
[Bug 1918] New: match_pattern_list fails for negated failure
https://bugzilla.mindrot.org/show_bug.cgi?id=1918 Bug #: 1918 Summary: match_pattern_list fails for negated failure Classification: Unclassified Product: Portable OpenSSH Version: 5.8p2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: sshd AssignedTo: unassigned-bugs at mindrot.org ReportedBy: robin at reportlab.com Created attachment 2061 --> https://bugzilla.mindrot.org/attachment.cgi?id=2061 patch to fix the 'bug' The code in match_pattern_list will never return 1 for a pattern with all negated entries. In particular this match line can never succeed Match User !adminguy Group sftponly The problem is that the code at match.c line 157 only tests for negation in the case of successful matching. In this case we want the User test to succeed if the user is not adminguy. That can happen if the code is patched to set get_positive if a failed match is negated. The attached trivial patch does that. Of course I am making the rather feeble assumption that negated failure == true -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2011-Jul-11 07:22 UTC
[Bug 1918] match_pattern_list fails for negated failure
https://bugzilla.mindrot.org/show_bug.cgi?id=1918 Tomas Mraz <t8m at centrum.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2061|application/octet-stream |text/plain mime type| | Attachment #2061|0 |1 is patch| | -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2011-Oct-21 00:13 UTC
[Bug 1918] match_pattern_list fails for negated failure
https://bugzilla.mindrot.org/show_bug.cgi?id=1918 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |djm at mindrot.org Blocks| |1930 -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2012-Feb-23 23:34 UTC
[Bug 1918] match_pattern_list fails for negated failure
https://bugzilla.mindrot.org/show_bug.cgi?id=1918 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1986 --- Comment #1 from Damien Miller <djm at mindrot.org> 2012-02-24 10:34:29 EST --- Retarget from 6.0 to 6.1 -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2012-Feb-23 23:38 UTC
[Bug 1918] match_pattern_list fails for negated failure
https://bugzilla.mindrot.org/show_bug.cgi?id=1918 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|1930 | --- Comment #2 from Damien Miller <djm at mindrot.org> 2012-02-24 10:38:08 EST --- Retarget 6.0 => 6.1 -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
Apparently Analagous Threads
- [Bug 1918] match_pattern_list fails for negated failure
- [Bug 1918] match_pattern_list fails for negated failure
- [Bug 1918] match_pattern_list fails for negated failure
- [Bug 1918] match_pattern_list fails for negated failure
- [Bug 1918] match_pattern_list fails for negated failure