bugzilla-daemon at bugzilla.mindrot.org
2010-Mar-26 21:47 UTC
[Bug 1744] New: libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 Summary: libedit support shouldn't assume -lcurses Product: Portable OpenSSH Version: -current Platform: Other OS/Version: Other Status: NEW Severity: minor Priority: P2 Component: Build system AssignedTo: unassigned-bugs at mindrot.org ReportedBy: imorgan at nas.nasa.gov Created an attachment (id=1824) --> (https://bugzilla.mindrot.org/attachment.cgi?id=1824) Use pkg-config to determine linker options for libedit Currently, building sftp with libedit support assumes that -ledit depends on -lcurses. However, libedit may depend on -lncurses or -ltermcap instead. On SLES 10 for example, libncurses may exist but not libcurses. Perhaps pkg-config should be used to check what libraries are required. -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 00:46 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 Darren Tucker <dtucker at zip.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dtucker at zip.com.au Blocks| |1743 --- Comment #1 from Darren Tucker <dtucker at zip.com.au> 2010-04-09 10:46:41 EST --- Seems reasonable, however I think it needs to test for the success of "pkg-config --libs-only-l libedit" not just the existence of pkg-config, so it'll still work on systems where libedit is installed but does not have a libedit.pc file (like mine :-). -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 01:23 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 --- Comment #2 from Darren Tucker <dtucker at zip.com.au> 2010-04-09 11:23:13 EST --- Created an attachment (id=1832) --> (https://bugzilla.mindrot.org/attachment.cgi?id=1832) openssh-libedit-pkgconfig.patch Use pkg-config for libedit only if pkg-config is found, it knows about libedit and --with-libedit does not specify a directory. -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 01:24 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 Darren Tucker <dtucker at zip.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1832|0 |1 is patch| | Attachment #1832| |ok?(djm at mindrot.org) Flag| | -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 01:47 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 --- Comment #3 from Darren Tucker <dtucker at zip.com.au> 2010-04-09 11:47:12 EST --- Created an attachment (id=1833) --> (https://bugzilla.mindrot.org/attachment.cgi?id=1833) openssh-libedit-pkgconfig.patch Merge two if blocks into one if/else block. -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 01:48 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 Darren Tucker <dtucker at zip.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1833|openssh-libedit-pkgconfig.p |Also uses pkg-config for description|atch |cflags if we decide to use | |pkg-config. Attachment #1833|0 |1 is patch| | Attachment #1833| |ok?(djm at mindrot.org) Flag| | -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 01:48 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 Darren Tucker <dtucker at zip.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1832|0 |1 is obsolete| | Attachment #1832|ok?(djm at mindrot.org) | Flag| | -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 01:49 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 Darren Tucker <dtucker at zip.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1824|0 |1 is obsolete| | -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 03:53 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1833|ok?(djm at mindrot.org) |ok+ Flag| | -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 04:05 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 Darren Tucker <dtucker at zip.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Darren Tucker <dtucker at zip.com.au> 2010-04-09 14:05:49 EST --- Thanks all, patch applied and will be in 5.5p1. -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 04:36 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 --- Comment #5 from Darren Tucker <dtucker at zip.com.au> 2010-04-09 14:36:15 EST --- Created an attachment (id=1834) --> (https://bugzilla.mindrot.org/attachment.cgi?id=1834) openssh-libedit-pkgconfig.patch -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-09 04:51 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 Darren Tucker <dtucker at zip.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1834|0 |1 is obsolete| | --- Comment #6 from Darren Tucker <dtucker at zip.com.au> 2010-04-09 14:51:30 EST --- (From update of attachment 1834) oops, accidentally reran the "bugz" command and reattached this file. please ignore -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-16 05:51 UTC
[Bug 1744] libedit support shouldn't assume -lcurses
https://bugzilla.mindrot.org/show_bug.cgi?id=1744 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Damien Miller <djm at mindrot.org> 2010-04-16 15:51:02 EST --- Mass move of bugs RESOLVED->CLOSED following the release of openssh-5.5p1 -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.