bugzilla-daemon at bugzilla.mindrot.org
2010-Mar-23 11:46 UTC
[Bug 1738] New: openbsd-compat wants xstrdup but it's in libssh.a
https://bugzilla.mindrot.org/show_bug.cgi?id=1738 Summary: openbsd-compat wants xstrdup but it's in libssh.a Product: Portable OpenSSH Version: 5.4p1 Platform: Other OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Build system AssignedTo: unassigned-bugs at mindrot.org ReportedBy: alanh at fairlite.co.uk Created an attachment (id=1816) --> (https://bugzilla.mindrot.org/attachment.cgi?id=1816) provide provde xstrdup for bsd-misc.c When building a static only openssh the link order is -lssh -lopenbsd-compat. But xstrdup exists in bsd-misc.c (and an aix file). The problem is that on a static only build xstrdup is in libssh.a and yet openbsd-compat needs it and fails because of the link order. This patch adds a private copy of xstrdup to bsd-misc.c but doesn't fix the aix file, as most will probably never build static only on AIX. -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Mar-23 12:22 UTC
[Bug 1738] openbsd-compat wants xstrdup but it's in libssh.a
https://bugzilla.mindrot.org/show_bug.cgi?id=1738 --- Comment #1 from Alan Hourihane <alanh at fairlite.co.uk> 2010-03-23 23:22:24 EST --- The patch is broken as it uses xmalloc() and suffers the same linkage problem. Sorry about that, a bit hasty with the patch. We'd need to duplicate xmalloc into here too. But maybe you guys have a better solution ? Or perhaps do "-lssh -lopenbsd-compat -lssh" for the pksc11-helper application ? then no patch would be required to bsd-misc.c -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Mar-23 14:44 UTC
[Bug 1738] openbsd-compat wants xstrdup but it's in libssh.a
https://bugzilla.mindrot.org/show_bug.cgi?id=1738 Alan Hourihane <alanh at fairlite.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1816|0 |1 is obsolete| | --- Comment #2 from Alan Hourihane <alanh at fairlite.co.uk> 2010-03-24 01:44:30 EST --- Created an attachment (id=1817) --> (https://bugzilla.mindrot.org/attachment.cgi?id=1817) add -lssh again to link pksc11-helper -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Mar-25 23:28 UTC
[Bug 1738] openbsd-compat wants xstrdup but it's in libssh.a
https://bugzilla.mindrot.org/show_bug.cgi?id=1738 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |djm at mindrot.org Blocks| |1708 Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Damien Miller <djm at mindrot.org> 2010-03-26 10:28:27 EST --- Already fixed in -current: http://anoncvs.mindrot.org/index.cgi/openssh/Makefile.in?view=log The fix will be in openssh-5.5p1, due shortly. -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Mar-25 23:43 UTC
[Bug 1738] openbsd-compat wants xstrdup but it's in libssh.a
https://bugzilla.mindrot.org/show_bug.cgi?id=1738 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|1708 |1743 -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Apr-16 05:50 UTC
[Bug 1738] openbsd-compat wants xstrdup but it's in libssh.a
https://bugzilla.mindrot.org/show_bug.cgi?id=1738 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Damien Miller <djm at mindrot.org> 2010-04-16 15:50:41 EST --- Mass move of bugs RESOLVED->CLOSED following the release of openssh-5.5p1 -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.