openssh bugs - Feb 2010 - [Bug 1711] New: openssh-client: recreate mux control socket

https://bugzilla.mindrot.org/show_bug.cgi?id=1711

           Summary: openssh-client: recreate mux control socket
           Product: Portable OpenSSH
           Version: 5.3p1
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ssh
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: bugzilla at tut.by


Created an attachment (id=1790)
 --> (https://bugzilla.mindrot.org/attachment.cgi?id=1790)
patch to re-create mux control socket

Hello.

This patch enables re-creation of the control socket for multiplexing.
Without it, if ssh dies, it leaves socket in place, and newly started
ssh cannot bind to it.

I've posted this at Debian bugtracker. Colin Watson suggested there:
==It seems to me that this patch makes it a bit too easy to accidentally
trash an existing master just by setting ControlMaster to "yes",
though.
Wouldn't it be better to do something like pinging the master to find
out if it's dead before recreating the socket, and disable multiplexing
as before if it's still alive?  That way there'd be no question about
whether it's appropriate to recreate the socket.  You could do the same
kind of thing as 'ssh -O check' does.
==
It seems that ssh does muxclient() call before trying to create the new
socket, so this should not be issue, but please re-check this.

Thanks.

-- 
WBR, Andrew

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1711

Andrew O. Shadoura <bugzilla at tut.by> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://bugs.debian.org/cgi-
                   |                            |bin/bugreport.cgi?bug=56901
                   |                            |8
           Keywords|                            |patch

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1711

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1803
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Damien Miller <djm at mindrot.org> 2010-09-24 22:20:14
EST ---
OpenSSH -current now atomically establishes a listening mux master
socket at the specified location, so a client encountering a mux master
socket that refuses connection can safely delete it and process to
establish its own. This change will be released in OpenSSH 5.7, due in
a couple of months.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1711

--- Comment #2 from Andrew O. Shadoura <bugzilla at tut.by> 2010-09-25
00:14:56 EST ---
Thanks, Damien.

Can you provide a link to the vcs diff?

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1711

--- Comment #3 from Andrew O. Shadoura <bugzilla at tut.by> 2010-09-25
00:20:12 EST ---
Ah, found it.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1711

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Damien Miller <djm at mindrot.org> 2011-01-24 12:33:37
EST ---
Move resolved bugs to CLOSED after 5.7 release

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.