openssh bugs - Mar 2009 - [Bug 1568] New: ssh-rand-helper ignores incorrect command line arguments

https://bugzilla.mindrot.org/show_bug.cgi?id=1568

           Summary: ssh-rand-helper ignores incorrect command line
                    arguments
           Product: Portable OpenSSH
           Version: 5.2p1
          Platform: ix86
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: ssh-rand-helper
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: gson at araneus.fi


Created an attachment (id=1611)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1611)
Patch

If you mistakenly run the command

  ssh-rand-helper 256

expecting it to return 256 bytes of output, ssh-rand-helper silently
ignores the error on the command line and returns 48 bytes of output.
It would be helpful to get an usage message in this case.

Also, if you enter an illegal command line option, say,

  ssh-rand-helper -z

ssh-rand-helper does print a usage message, but it will otherwise
ignore the error and will return an exit status of zero.  It would
seem more prudent to treat this as a fatal error.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1568

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1626
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Damien Miller <djm at mindrot.org> 2009-11-20 15:17:03
EST ---
Applied - thanks for the patch. This will be in openssh-5.4.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1568

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> 2010-03-26
10:52:01 EST ---
With the release of 5.4p1, this bug is now considered closed.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.