openssh bugs - Feb 2009 - [Bug 1555] New: add hard link and attribute extensions to sftp-server

https://bugzilla.mindrot.org/show_bug.cgi?id=1555

           Summary: add hard link and attribute extensions to sftp-server
           Product: Portable OpenSSH
           Version: 5.1p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: sftp-server
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: miklos at szeredi.hu


Hard links are not used very often nowdays, but they do still have
their uses and this is currently the most often requested improvement
for SSHFS.

To detect hard links the st_nlink, st_dev and st_ino attributes are
usually used.

I'll be attaching patches that add a hard link operation and extend the
protocol to include all the common UNIX file attributes.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555





--- Comment #1 from Miklos Szeredi <miklos at szeredi.hu>  2009-02-13
22:05:28 ---
Created an attachment (id=1601)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1601)
hard link protocol extension for sftp

This patch that adds support for the creation of hard links over SFTP.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555





--- Comment #2 from Miklos Szeredi <miklos at szeredi.hu>  2009-02-13
22:07:57 ---
Created an attachment (id=1602)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1602)
add protocol extension to ATTR message

This patch adds all the missing commonly used UNIX attributes: st_dev,
st_ino, st_nlink, st_rdev, st_blocks, st_blksize, st_ctime.  In
addition it extends st_atime and st_mtime to 64bits, and adds
nanosecond resolution to all three timestamps.

This is implemented as an extension to the ATTR message.  This patch
alone is sufficient for SSHFS to be able to use these attributes.  The
following two patches optimize the bandwidth use for this extension.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555





--- Comment #3 from Miklos Szeredi <miklos at szeredi.hu>  2009-02-13
22:10:54 ---
Created an attachment (id=1603)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1603)
 add attribute configuration message

This patch adds a new extended request with which the client can
request which attributes it wants to receive.  By default only the
basic attributes are transferred, but the client can request that any
subset of the basic or extra attributes to be sent.  Attributes can be
selected separately for STAT and READDIR requests.

Also there's a flag to turn off the generation of long names in
READDIR requests.

The server also sends the attributes it can actually support in the
attribute configuration reply so the client may make decisions based
on the server's capabilities.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555





--- Comment #4 from Miklos Szeredi <miklos at szeredi.hu>  2009-02-13
22:11:41 ---
Created an attachment (id=1604)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1604)
optimize attribute sending

This patch turns off sending unnecessary attributes:

  - the nanosecond part of timestamps if they are zero
  - the 32bit atime and mtime if the 64bit atime/mtime are sent

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555

Tom Fredrik Blenning Klaussen <bfg-dev at blenning.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bfg-dev at blenning.no

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555

Bert Haverkamp <bert at bertenselena.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bert at bertenselena.net

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555

David Rosenstrauch <darose at darose.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darose at darose.net

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555

--- Comment #5 from David Rosenstrauch <darose at darose.net> 2010-03-17
08:31:52 EST ---
Just wondering:  are there any plans to integrate these patches into a
release at some point?

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1708

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555

--- Comment #6 from Damien Miller <djm at mindrot.org>  ---
We are freezing for the OpenSSH 5.6 release. Retargetting these bugs to
the next release.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1708                        |1803

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555

--- Comment #7 from Damien Miller <djm at mindrot.org> 2010-12-03 12:25:37
EST ---
Created attachment 1971
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1971
/home/djm/sftp-hardlink.diff

revised patch

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1555

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1803                        |
            Summary|add hard link and attribute |add  attribute extensions
                   |extensions to sftp-server   |to sftp-server

--- Comment #8 from Damien Miller <djm at mindrot.org> 2010-12-04 11:18:50
EST ---
hard link patch is submitted and will be released in OpenSSH 5.7

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.