openssh bugs - Mar 2008 - [Bug 1447] New: sftp-server rename fails when EXDEV is returned

https://bugzilla.mindrot.org/show_bug.cgi?id=1447

           Summary: sftp-server rename fails when EXDEV is returned        
    Classification: Unclassified                                           
           Product: Portable OpenSSH                                       
           Version: 4.7p1                                                  
          Platform: All                                                    
        OS/Version: Linux                                                  
            Status: NEW                                                    
          Keywords: patch                                                  
          Severity: normal                                                 
          Priority: P2                                                     
         Component: sftp-server                                            
        AssignedTo: bitbucket at mindrot.org                                  
        ReportedBy: mgarrison at alienz.net                                   


Created an attachment (id=1459)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1459)
fix rename

One of the complaints we've commonly gotten from users is that modern
versions of OpenSSH do not allow users to rename files in AFS across
directories. Since OpenAFS only allows hardlinks in the parent
directory, you can rename in the same directory but not across  
directory boundaries.

This is the same behavior when you try to rename across regular
partition boundaries, as a hardlink will fail with EXDEV. This patch
fails over to doing a racy rename if EXDEV is returned.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1447


Mike Garrison <mgarrison at alienz.net> changed:

           What    |Removed                     |Added                       
----------------------------------------------------------------------------
   Attachment #1459|0                           |1                           
        is obsolete|                            |                            




--- Comment #1 from Mike Garrison <mgarrison at alienz.net>  2008-03-06
03:32:39 ---
Created an attachment (id=1460)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1460)
fix rename if EXDEV is returned

Helps if I make sure the patch is actually correct. Oops.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1447





--- Comment #2 from Mike Garrison <mgarrison at alienz.net>  2008-05-30
00:53:01 ---
Greetings,

I haven't heard anything regarding this patch. Is the patch okay? Is
there something more that needs to be done?

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1447


Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au




--- Comment #3 from Darren Tucker <dtucker at zip.com.au>  2008-06-13
09:25:29 ---
Under what circumstances does rename(2) work across filesystems? 
According to the rename(2) man page on my fedora box:

  EXDEV  oldpath and newpath are not  on  the  same  mounted 
filesystem.
         (Linux  permits  a  filesystem to be mounted at multiple
points,
         but rename(2) does not work across different mount points, 
even
         if the same filesystem is mounted on both.)

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1447





--- Comment #4 from Mike Garrison <mgarrison at alienz.net>  2008-06-19
05:17:36 ---
(In reply to comment #3)

In OpenAFS, the ACL information is stored in the directory, which is
why EXDEV is returned when you try to hardlink across directories.
However, doing a rename works fine. 

Older versions (eg, 3.8) handled this fine, it was only when the if ()
blocks checking to see if errno was EOPNOTSUPP or LINK_OPNOTSUPP_ERRNO
did this stop working.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1447


Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
             Blocks|                            |1452




--- Comment #5 from Darren Tucker <dtucker at zip.com.au>  2008-07-04
14:11:58 ---
Patch applied (with an #ifdef, since not all platforms have EXDEV) and
will be in 5.1.  Thanks.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1447


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




--- Comment #6 from Damien Miller <djm at mindrot.org>  2008-07-22
12:21:29 ---
Mass update RESOLVED->CLOSED after release of openssh-5.1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.