openssh bugs - Jul 2007 - [Bug 1347] New: LLONG_MAX v LONGLONG_MAX

http://bugzilla.mindrot.org/show_bug.cgi?id=1347

           Summary: LLONG_MAX v LONGLONG_MAX
           Product: Portable OpenSSH
           Version: 4.6p1
          Platform: PPC
        OS/Version: AIX
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Miscellaneous
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: David.Leonard at quest.com


On AIX, LLONG_MAX is known as LONGLONG_MAX


/data/rc/u/davidl/openssh/openssh/openbsd-compat/regress/strtonumtest.c:
In function `test':
/data/rc/u/davidl/openssh/openssh/openbsd-compat/regress/strtonumtest.c:32:
warning: implicit declaration
 of function `strtonum'
/data/rc/u/davidl/openssh/openssh/openbsd-compat/regress/strtonumtest.c:
In function `main':
/data/rc/u/davidl/openssh/openssh/openbsd-compat/regress/strtonumtest.c:49:
`LLONG_MAX' undeclared (first
 use in this function)
/data/rc/u/davidl/openssh/openssh/openbsd-compat/regress/strtonumtest.c:49:
(Each undeclared identifier i
s reported only once
/data/rc/u/davidl/openssh/openssh/openbsd-compat/regress/strtonumtest.c:49:
for each function it appears 
in.)
/data/rc/u/davidl/openssh/openssh/openbsd-compat/regress/strtonumtest.c:53:
`LLONG_MIN' undeclared (first
 use in this function)
gmake[3]: Leaving directory
`/var/tmp/build.openssh.build/build/openssh-4.6p1/open

/usr/include/sys/limits.h:#define LONGLONG_MAX  (0x7fffffffffffffffLL)
/usr/include/sys/limits.h:#define LONGLONG_MIN  (-LONGLONG_MAX - 1)

I notice that there is a test for HAVE_LLONG_MAX in configure.in ...
maybe that could be used instead of what i did in the attached patch??


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1347





--- Comment #1 from David Leonard <David.Leonard at quest.com>  2007-07-30
14:39:14 ---
Created an attachment (id=1333)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1333)
define LLONG_MAX if LONGLONG_MAX is defined


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1347


David Leonard <David.Leonard at quest.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1333 is|0                           |1
           obsolete|                            |




--- Comment #2 from David Leonard <David.Leonard at quest.com>  2007-09-24
23:03:11 ---
Created an attachment (id=1360)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1360)
define LLONG_MAX on AIX and HP-UX

This bug also affects HP-UX. I've attached an updated patch that uses
LONG_LONG_MAX from HP-UX's <limits.h> as well.

This allows "make compat-tests" to pass on AIX and HP-UX.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1347


Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added                       
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED                    
         Resolution|                            |FIXED                       
                 CC|                            |dtucker at zip.com.au          
             Blocks|                            |1353                        




--- Comment #3 from Darren Tucker <dtucker at zip.com.au>  2008-03-09
17:10:39 ---
Patch applied, will be in 4.8.  Thanks!

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1347


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added                       
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED                      




--- Comment #4 from Damien Miller <djm at mindrot.org>  2008-03-31
15:20:50 ---
Fix shipped in 4.9/4.9p1 release.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.