openssh bugs - May 2005 - [Bug 950] terminal settings not restored after Ctrl+C during password prompt in scp/sftp

http://bugzilla.mindrot.org/show_bug.cgi?id=950


peak at argo.troja.mff.cuni.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




------- Additional Comments From peak at argo.troja.mff.cuni.cz  2005-05-06
01:06 -------
Damn it! There is another nasty subtle race condition there: kill() from the
parent (e.g. scp) can interrupt tcsetattr() in the child (ssh), make it fail
with EINTR (both POSIX and OpenBSD documentation says tcsetattr() can be
interrupted by a signal) and leave the tty in a broken state. Observed on
3.8.1p1 on Linux 2.4 on a SMP machine (well, it was not a true SMP box, it was a
single Xeon in HT mode). As far as I can tell, every version using OpenBSD
readpassphrase() up to the current snapshot is affected.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=950





------- Additional Comments From peak at argo.troja.mff.cuni.cz  2005-05-06
01:08 -------
Created an attachment (id=898)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=898&action=view)
possible fix

This patch makes readpassphrase() retry tcsetattr() when it fails with EINTR.
It appears to solve the problem.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=950


t8m at centrum.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t8m at centrum.cz






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=950


djm at mindrot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From djm at mindrot.org  2005-05-24 16:01 -------
Applied to -portable and submitted to OpenBSD libc.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.