openssh bugs - Oct 2004 - [Bug 940] xmmap.c noequality compile error on DigitalUNIX 4.0F PK7

http://bugzilla.mindrot.org/show_bug.cgi?id=940

           Summary: xmmap.c noequality compile error on DigitalUNIX 4.0F PK7
           Product: Portable OpenSSH
           Version: 3.9p1
          Platform: Alpha
        OS/Version: OSF/1
            Status: NEW
          Severity: critical
          Priority: P2
         Component: Build system
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: anenni at isisw.com


On Digital UNIX 4.0F (patch-kit 7), after configure with only zlib path, make
command fails with this error:

root at plutone/var/appoggio/openssh-3.9p1# make
(cd openbsd-compat && make)
cc -std1 -g -I. -I.. -I. -I./.. -I/usr/local/ssl/include -I/usr/local/include 
-DHAVE_CONFIG_H -c xmmap.c
cc: Error: xmmap.c, line 50: In this statement, "address" and
"(-1)" cannot be
compared for equality or inequality. (noequality)
        if (address == MAP_FAILED) {
------------^
*** Exit 1
Stop.
*** Exit 1
Stop.

Openssh 3.8.1p1 compiles fine giving just this warning:

cc -g -I. -I.. -I. -I./.. -I/usr/local/ssl/include -I/usr/local/include 
-DHAVE_CONFIG_H -c xmmap.c
cc: Warning: xmmap.c, line 50: In this statement, "(-1)" of type
"long", is
being converted to "pointer to void". (cvtdiftypes)
        if (address == MAP_FAILED) {
------------^



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=940





------- Additional Comments From dtucker at zip.com.au  2004-10-06 08:21 -------
I can't see why that would fail in 3.9p1 and work in 3.8.1p1 since xmmap.c
has
changed only minimally and that chunk of code hasn't changed at all.

Can you try casting the constant to void *, ie change:
if (address == MAP_FAILED) {
to:
if (address == (void *)MAP_FAILED) {



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=940

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcaskill.scott at epa.gov



------- Additional Comments From dtucker at zip.com.au  2004-10-06 21:47 -------
*** Bug 929 has been marked as a duplicate of this bug. ***



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.