openssh bugs - Jun 2003 - [Bug 602] enormous bitching about netdb.h

http://bugzilla.mindrot.org/show_bug.cgi?id=602

           Summary: enormous bitching about netdb.h
           Product: Portable OpenSSH
           Version: 3.6.1p2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Build system
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: tedm at toybox.placo.com


System is Sparc running Solaris 2.5.1

when typing "make" I get the following error on just about every
single
.c file compiled, here is a sample:

In file included from includes.h:54,
                 from authfd.c:37:
/usr/include/netdb.h:195: warning: `struct sockaddr_in' declared inside 
parameter list
/usr/include/netdb.h:195: warning: its scope is only this definition or 
declaration, which is probably not what you want.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=602





------- Additional Comments From dtucker at zip.com.au  2003-06-24 19:00 -------
In which header file under /usr/include is "struct sockaddr_in"
defined?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=602





------- Additional Comments From tedm at toybox.placo.com  2003-06-24 20:46
-------
it appears to be /usr/include/netinet/in.h



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=602





------- Additional Comments From dtucker at zip.com.au  2003-06-24 21:03 -------
In includes.h, try moving the line "#include <netinet/in.h>" to
just before the
line "#include <netdb.h>" and see if that stops the errors.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=602





------- Additional Comments From tedm at toybox.placo.com  2003-06-24 21:25
-------
yes that appears to have fixed the problem.

Most of the source files build without complaints now.  There are a few
that have other complaints such as

-helper\" -DHAVE_CONFIG_H -c xmalloc.c
xmalloc.c: In function `xstrdup':
xmalloc.c:66: warning: implicit declaration of function `strlcpy'

and

misc.c: In function `set_nodelay':
misc.c:99: warning: passing arg 4 of `getsockopt' from incompatible pointer
type
misc.c:109: warning: passing arg 4 of `setsockopt' from incompatible pointer
type

that are isolated to just a few files.  Would you like a list of these?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=602





------- Additional Comments From djm at mindrot.org  2003-06-24 21:33 -------
Bug #565 is for compiler warnings, attach them to it.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=602





------- Additional Comments From dtucker at zip.com.au  2003-06-24 22:09 -------
Should includes.h be reordered, what's the best order to avoid breaking 
something else?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=602





------- Additional Comments From djm at mindrot.org  2003-06-28 17:54 -------
make the change and see what breaks :)

I think moving netdb.h to below netinet/in.h is pretty safe though.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=602

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From dtucker at zip.com.au  2003-06-29 21:25 -------
Moved include of netdb.h: 
20030629
 - (dtucker) Bug #602: move #include of netdb.h to after in.h (fixes compiler
   warnings on Solaris 2.5.1).




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.