Christoph Hellwig
2020-Feb-19 14:52 UTC
[Ocfs2-devel] [PATCH v6 07/19] mm: Put readahead pages in cache earlier
On Wed, Feb 19, 2020 at 06:41:17AM -0800, Matthew Wilcox wrote:> #define readahead_for_each(rac, page) \ > while ((page = readahead_page(rac))) > > No more readahead_next() to forget to add to filesystems which don't use > the readahead_for_each() iterator. Ahem.And then kill readahead_for_each and open code the above to make it even more obvious?
Matthew Wilcox
2020-Feb-19 15:01 UTC
[Ocfs2-devel] [PATCH v6 07/19] mm: Put readahead pages in cache earlier
On Wed, Feb 19, 2020 at 06:52:46AM -0800, Christoph Hellwig wrote:> On Wed, Feb 19, 2020 at 06:41:17AM -0800, Matthew Wilcox wrote: > > #define readahead_for_each(rac, page) \ > > while ((page = readahead_page(rac))) > > > > No more readahead_next() to forget to add to filesystems which don't use > > the readahead_for_each() iterator. Ahem. > > And then kill readahead_for_each and open code the above to make it > even more obvious?Makes sense.