Joseph Qi
2019-Dec-03 01:05 UTC
[Ocfs2-devel] [PATCH] ocfs2/dlm: remove redundant assignment to ret
On 19/12/3 00:48, Colin King wrote:> From: Colin Ian King <colin.king at canonical.com> > > The variable ret is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king at canonical.com>Reviewed-by: Joseph Qi <joseph.qi at linux.alibaba.com>> --- > fs/ocfs2/dlm/dlmrecovery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c > index 064ce5bbc3f6..2734867473a6 100644 > --- a/fs/ocfs2/dlm/dlmrecovery.c > +++ b/fs/ocfs2/dlm/dlmrecovery.c > @@ -1668,7 +1668,7 @@ static int dlm_lockres_master_requery(struct dlm_ctxt *dlm, > int dlm_do_master_requery(struct dlm_ctxt *dlm, struct dlm_lock_resource *res, > u8 nodenum, u8 *real_master) > { > - int ret = -EINVAL; > + int ret; > struct dlm_master_requery req; > int status = DLM_LOCK_RES_OWNER_UNKNOWN; > >