Ocfs2 devel - Oct 2017 - a puzzle about is_global_system_inode function

Hi all,

Function is_global_system_inode checks whether the type is
in the range [OCFS2_FIRST_ONLINE_SYSTEM_INODE , 
OCFS2_LAST_GLOBAL_SYSTEM_INODE ].
But why the range does not include GLOBAL_INODE_ALLOC_SYSTEM_INODE ??

enum {
 ????? ....
 ?????? GLOBAL_INODE_ALLOC_SYSTEM_INODE,
 ??????? SLOT_MAP_SYSTEM_INODE,
#define OCFS2_FIRST_ONLINE_SYSTEM_INODE SLOT_MAP_SYSTEM_INODE
 ??????? HEARTBEAT_SYSTEM_INODE,
 ??????? GLOBAL_BITMAP_SYSTEM_INODE,
 ??????? USER_QUOTA_SYSTEM_INODE,
 ??????? GROUP_QUOTA_SYSTEM_INODE,
#define OCFS2_LAST_GLOBAL_SYSTEM_INODE GROUP_QUOTA_SYSTEM_INODE
 ??? ....
}

Thanks
Larry Chen

GLOBAL_INODE_ALLOC_SYSTEM_INODE is used for system files inode
allocation, you can refer to ocfs2-tools for details.

Thanks,
Joseph

On 17/10/24 18:39, Larry Chen wrote:
> Hi all,
> 
> Function is_global_system_inode checks whether the type is
> in the range [OCFS2_FIRST_ONLINE_SYSTEM_INODE , 
> OCFS2_LAST_GLOBAL_SYSTEM_INODE ].
> But why the range does not include GLOBAL_INODE_ALLOC_SYSTEM_INODE ??
> 
> enum {
>  ????? ....
>  ?????? GLOBAL_INODE_ALLOC_SYSTEM_INODE,
>  ??????? SLOT_MAP_SYSTEM_INODE,
> #define OCFS2_FIRST_ONLINE_SYSTEM_INODE SLOT_MAP_SYSTEM_INODE
>  ??????? HEARTBEAT_SYSTEM_INODE,
>  ??????? GLOBAL_BITMAP_SYSTEM_INODE,
>  ??????? USER_QUOTA_SYSTEM_INODE,
>  ??????? GROUP_QUOTA_SYSTEM_INODE,
> #define OCFS2_LAST_GLOBAL_SYSTEM_INODE GROUP_QUOTA_SYSTEM_INODE
>  ??? ....
> }
> 
> Thanks
> Larry Chen
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>

Hi Larry Chen,

I think the reason is because the GLOBAL_INODE_ALLOC_SYSTEM_INODE
is just used when the device is offline, such as used in mkfs.ocfs2
and tunefs.ocfs2, it is not needed when the device is online.

Thanks
Alex

On 2017/10/24 18:39, Larry Chen wrote:
> Hi all,
> 
> Function is_global_system_inode checks whether the type is
> in the range [OCFS2_FIRST_ONLINE_SYSTEM_INODE , 
> OCFS2_LAST_GLOBAL_SYSTEM_INODE ].
> But why the range does not include GLOBAL_INODE_ALLOC_SYSTEM_INODE ??
> 
> enum {
>        ....
>         GLOBAL_INODE_ALLOC_SYSTEM_INODE,
>          SLOT_MAP_SYSTEM_INODE,
> #define OCFS2_FIRST_ONLINE_SYSTEM_INODE SLOT_MAP_SYSTEM_INODE
>          HEARTBEAT_SYSTEM_INODE,
>          GLOBAL_BITMAP_SYSTEM_INODE,
>          USER_QUOTA_SYSTEM_INODE,
>          GROUP_QUOTA_SYSTEM_INODE,
> #define OCFS2_LAST_GLOBAL_SYSTEM_INODE GROUP_QUOTA_SYSTEM_INODE
>      ....
> }
> 
> Thanks
> Larry Chen
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>