Darrick J. Wong
2017-May-31 16:03 UTC
[Ocfs2-devel] [PATCH 09/28] ext4: extended attribute value size limit is enforced by vfs
On Wed, May 31, 2017 at 01:14:58AM -0700, Tahsin Erdogan wrote:> EXT4_XATTR_MAX_LARGE_EA_SIZE definition in ext4 is currently unused. > Besides, vfs enforces its own 64k limit which makes the 1MB limit in > ext4 redundant. Remove it. > > Signed-off-by: Tahsin Erdogan <tahsin at google.com> > --- > fs/ext4/ext4.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > index 5d5fc0d0e2bc..2cdd6070e348 100644 > --- a/fs/ext4/ext4.h > +++ b/fs/ext4/ext4.h > @@ -2221,12 +2221,6 @@ struct mmpd_data { > #define EXT4_MMP_MAX_CHECK_INTERVAL 300UL > > /* > - * Maximum size of xattr attributes for FEATURE_INCOMPAT_EA_INODE 1Mb > - * This limit is arbitrary, but is reasonable for the xattr API. > - */ > -#define EXT4_XATTR_MAX_LARGE_EA_SIZE (1024 * 1024)Uhhh... didn't you add this in patch 1/28? There's little point in adding a symbol just to delete it shortly thereafter. --D> - > -/* > * Function prototypes > */ > > -- > 2.13.0.219.gdb65acc882-goog >