Sunil Mushran
2009-Aug-19 22:16 UTC
[Ocfs2-devel] [PATCH 1/1] ocfs2: __ocfs2_abort() should not enable panic for local mounts
In a clustered setup, we have to panic the box on journal abort. This is because we don't have the facility to go hard readonly. With hard ro, another node would detect node failure and initiate recovery. Having said that, we shouldn't force panic if the volume is mounted locally. This patch defers the handling to the mount option, errors. Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com> --- fs/ocfs2/super.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index b0ee0fd..44a0388 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c @@ -2486,7 +2486,8 @@ void __ocfs2_abort(struct super_block* sb, /* Force a panic(). This stinks, but it's better than letting * things continue without having a proper hard readonly * here. */ - OCFS2_SB(sb)->s_mount_opt |= OCFS2_MOUNT_ERRORS_PANIC; + if (!ocfs2_mount_local(OCFS2_SB(sb))) + OCFS2_SB(sb)->s_mount_opt |= OCFS2_MOUNT_ERRORS_PANIC; ocfs2_handle_error(sb); } -- 1.6.0.4
Joel Becker
2009-Aug-26 04:39 UTC
[Ocfs2-devel] [PATCH 1/1] ocfs2: __ocfs2_abort() should not enable panic for local mounts
On Wed, Aug 19, 2009 at 03:16:01PM -0700, Sunil Mushran wrote:> In a clustered setup, we have to panic the box on journal abort. This is > because we don't have the facility to go hard readonly. With hard ro, another > node would detect node failure and initiate recovery. > > Having said that, we shouldn't force panic if the volume is mounted locally. > This patch defers the handling to the mount option, errors. > > Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>This is now in the merge-window branch of ocfs2.git. Joel -- "Here's something to think about: How come you never see a headline like ``Psychic Wins Lottery''?" - Jay Leno Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127