Ocfs2 devel - Jul 2009 - [PATCH] Remove redundant BUG_ON in __dlm_queue_ast

Remove redundant BUG_ON()

Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de>
---

diff --git a/fs/ocfs2/dlm/dlmast.c b/fs/ocfs2/dlm/dlmast.c
index d07ddbe..81eff8e 100644
--- a/fs/ocfs2/dlm/dlmast.c
+++ b/fs/ocfs2/dlm/dlmast.c
@@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm, struct
dlm_lock *lock)
 		     lock->ast_pending, lock->ml.type);
 		BUG();
 	}
-	BUG_ON(!list_empty(&lock->ast_list));
 	if (lock->ast_pending)
 		mlog(0, "lock has an ast getting flushed right now\n");
 

-- 
Goldwyn

Can you explain why you think it is redundant?

Goldwyn Rodrigues wrote:
>     Remove redundant BUG_ON()
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de>
> ---
>
> diff --git a/fs/ocfs2/dlm/dlmast.c b/fs/ocfs2/dlm/dlmast.c
> index d07ddbe..81eff8e 100644
> --- a/fs/ocfs2/dlm/dlmast.c
> +++ b/fs/ocfs2/dlm/dlmast.c
> @@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm,
struct dlm_lock *lock)
>  		     lock->ast_pending, lock->ml.type);
>  		BUG();
>  	}
> -	BUG_ON(!list_empty(&lock->ast_list));
>  	if (lock->ast_pending)
>  		mlog(0, "lock has an ast getting flushed right now\n");
>  
>
>

Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>


Goldwyn Rodrigues wrote:
>     Remove redundant BUG_ON()
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de>
> ---
>
> diff --git a/fs/ocfs2/dlm/dlmast.c b/fs/ocfs2/dlm/dlmast.c
> index d07ddbe..81eff8e 100644
> --- a/fs/ocfs2/dlm/dlmast.c
> +++ b/fs/ocfs2/dlm/dlmast.c
> @@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm,
struct dlm_lock *lock)
>  		     lock->ast_pending, lock->ml.type);
>  		BUG();
>  	}
> -	BUG_ON(!list_empty(&lock->ast_list));
>  	if (lock->ast_pending)
>  		mlog(0, "lock has an ast getting flushed right now\n");
>  
>
>

On Fri, Jul 31, 2009 at 02:28:02PM -0500, Goldwyn Rodrigues
wrote:
>     Remove redundant BUG_ON()
> 
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de>
This is now in the fixes branch of ocfs2.git.

Joel

-- 

"Same dancers in the same old shoes.
 You get too careful with the steps you choose.
 You don't care about winning but you don't want to lose
 After the thrill is gone."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127