Tao Ma
2009-Apr-28 17:20 UTC
[Ocfs2-devel] [PATCH] ocfs2/trivial: Remove unused variable in ocfs2_rename.
With indexed dir enabled, now we use ocfs2_dir_lookup_result to wrap all the bh used for dir. So remove the 2 unused variables. Signed-off-by: Tao Ma <tao.ma at oracle.com> --- fs/ocfs2/namei.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 2220f93..33464c6 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -1025,10 +1025,8 @@ static int ocfs2_rename(struct inode *old_dir, struct inode *orphan_dir = NULL; struct ocfs2_dinode *newfe = NULL; char orphan_name[OCFS2_ORPHAN_NAMELEN + 1]; - struct buffer_head *orphan_entry_bh = NULL; struct buffer_head *newfe_bh = NULL; struct buffer_head *old_inode_bh = NULL; - struct buffer_head *insert_entry_bh = NULL; struct ocfs2_super *osb = NULL; u64 newfe_blkno, old_de_ino; handle_t *handle = NULL; @@ -1455,8 +1453,6 @@ bail: brelse(old_inode_bh); brelse(old_dir_bh); brelse(new_dir_bh); - brelse(orphan_entry_bh); - brelse(insert_entry_bh); mlog_exit(status); -- 1.5.5
Joel Becker
2009-Apr-29 18:28 UTC
[Ocfs2-devel] [PATCH] ocfs2/trivial: Remove unused variable in ocfs2_rename.
On Wed, Apr 29, 2009 at 01:20:55AM +0800, Tao Ma wrote:> With indexed dir enabled, now we use ocfs2_dir_lookup_result to > wrap all the bh used for dir. So remove the 2 unused variables. > > Signed-off-by: Tao Ma <tao.ma at oracle.com>Thanks Tao, this is added to the fixes branch. Joel -- "The real reason GNU ls is 8-bit-clean is so that they can start using ISO-8859-1 option characters." - Christopher Davis (ckd at loiosh.kei.com) Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127