I want to make a suggestion that we change from the usage of: #include <ocfs.h> To: #include "inc/ocfs.h" This should make for cleaner Makefiles that don't need to add a -I flag to add the inc/ directory. Any comments on this? Enclosed please find a patch which does this. John -------------- next part -------------- A non-text attachment was scrubbed... Name: include-fix.diff Type: application/octet-stream Size: 8257 bytes Desc: include-fix.diff Url : http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20040304/cb9d3e51/include-fix-0001.obj
On Thu, Mar 04, 2004 at 04:38:29PM -0800, Villalovos, John L wrote:> I want to make a suggestion that we change from the usage of: > > #include <ocfs.h> > > To: > > #include "inc/ocfs.h" > > This should make for cleaner Makefiles that don't need to add a -I flag > to add the inc/ directory. > > Any comments on this? > > Enclosed please find a patch which does this.Looks good. Committed. -Manish
On Thu, Mar 04, 2004 at 04:38:29PM -0800, Villalovos, John L wrote:> #include "inc/ocfs.h" > > This should make for cleaner Makefiles that don't need to add a -I flag > to add the inc/ directory. > > Any comments on this?Other way around, really. All in-kernel filesystems with headers have the headers in the flat directory. Joel -- Brain: I shall pollute the water supply with this DNAdefibuliser, turning everyone into mindless slaves. Pinky: What about the people who drink bottled water? Brain: Pinky, people who pay 5 dollars for a bottle of water are already mindless slaves. Joel Becker Senior Member of Technical Staff Oracle Corporation E-mail: joel.becker@oracle.com Phone: (650) 506-8127
> On Thu, Mar 04, 2004 at 04:38:29PM -0800, Villalovos, John L wrote: > > #include "inc/ocfs.h" > > > > This should make for cleaner Makefiles that don't need to > add a -I flag > > to add the inc/ directory. > > > > Any comments on this? > > Other way around, really. All in-kernel filesystems with > headers have the headers in the flat directory.I agree if you are saying that we should get rid of the "inc/" directory and move all the .h files into the src/ directory. That would make it more palatable to future integration with the kernel. IMHO :) John