Nut upsdev - Dec 2009 - libusb detection shell script (was Re: [nut-commits] svn commit r2218 - trunk/m4)

On Dec 31, 2009, at 8:45 AM, Arjen de Korte wrote:
> Author: adkorte-guest
> Date: Thu Dec 31 13:45:16 2009
> New Revision: 2218
>
> Log:
> Add pkg-config as method to retrieve CFLAGS and LDFLAGS (but fall  
> back to libusb-config)
>
> Modified:
>   trunk/m4/nut_check_libusb.m4
Arjen,

I'm not sure you want parentheses in the shell script fragments.

Search for "unexpected operator":
http://buildbot.ghz.cc/public/nut/FreeBSD-i686/builds/46/step-compile/0

- Charles

On Dec 31, 2009, at 6:43 PM, Charles Lepple wrote:
> On Dec 31, 2009, at 8:45 AM, Arjen de Korte wrote:
>
>> Author: adkorte-guest
>> Date: Thu Dec 31 13:45:16 2009
>> New Revision: 2218
>>
>> Log:
>> Add pkg-config as method to retrieve CFLAGS and LDFLAGS (but fall  
>> back to libusb-config)
>>
>> Modified:
>>  trunk/m4/nut_check_libusb.m4
>
> Arjen,
>
> I'm not sure you want parentheses in the shell script fragments.
>
> Search for "unexpected operator":
http://buildbot.ghz.cc/public/nut/FreeBSD-i686/builds/46/step-compile/0
I should clarify - parentheses are OK in general for shell scripts,  
but the punctuation around them can be troublesome. Also, the shell is  
supposed to spawn a new subshell for each parenthesized expression,  
which can get slow on older hardware with a shell like bash.

I'll play around with this later, but I figured I'd give you a heads- 
up as to why I will be messing with it.

Citeren Charles Lepple <clepple op ghz.cc>:
> I'm not sure you want parentheses in the shell script fragments.
I have no better explanation that "we did that in almost all m4  
macro's so far". You raise a good argument for removing them, so when  
updating them, I'll try to remember to remove them.

Best regards, Arjen
-- 
Please keep list traffic on the list