---------- Forwarded Message ---------- Subject: [PATCH] New to nut project Date: Friday, 6. November 2009 From: Patrick Levesque <patrickl at verint.com> To: Thomas Jarosch <thomas.jarosch at intra2net.com> As requested, here is my patch file including all my modification to the 2.4.1 tarball from the web site. On Friday 06 November 2009 05:41:29 you wrote:> Hello Patrick, > > On Wednesday, 4. November 2009 14:12:09 Levesque, Patrick wrote: > > I have tried to support a TrippLite Internet350SER UPS using a serial > > cable (The only connection on this model) using the 2.4 code branch. It > > uses the Protocol 1004 from the tripplite specification that can be use > > either used on serial or USB device. Since my device was only serial, I > > worked only on the serial integration. Since I found nothing in > > tripplite.c, tripplite-hid.c, tripplitesu.c to support my model, I have > > done trippliteser.c in order to support my unit. Not all the > > functionality are there but the core functionality is there. Since it > > is licence as GPLv2, I just want to push back my modifs to the community > > but really don't know the procedure. > > Do you know how diff/patch works? Just send your changes > as unified diff (diff -u) to the devel list. Might be a good > idea to prefix your mail subject with "[PATCH]". > > If possible, try to prevent winmail.dat attachments on the mailing list, > so people with a normal email client can open the attachment. > > Cheers, > Thomas-------------- next part -------------- A non-text attachment was scrubbed... Name: diff.patch Type: text/x-patch Size: 24117 bytes Desc: not available URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20091109/0ba36280/attachment.bin>
Hi Thomas, thanks for interfacing with Patrick on this point. btw, would you be interested in integrating the team? I'll leave up to Charles to check the patch. I don't know much about Tripplite protocols, but this one seems to be a variation of the existing ones (1001 and 3003, so maybe a 4004?!), which means that it could possibly be merged in the existing tripplite drivers. All in all, Charles will hopefully have comments... @Patrick: do you have a USB port too, or only a serial one? cheers, Arnaud -- Linux / Unix Expert R&D - Eaton - http://www.eaton.com/mgeops Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://www.debian.org Free Software Developer - http://arnaud.quette.free.fr/ 2009/11/9 Thomas Jarosch:> ---------- ?Forwarded Message ?---------- > > Subject: [PATCH] New to nut project > Date: Friday, 6. November 2009 > From: Patrick Levesque > To: Thomas Jarosch > > As requested, here is my patch file including all my modification to the > 2.4.1 > tarball from the web site. > > On Friday 06 November 2009 05:41:29 you wrote: >> Hello Patrick, >> >> On Wednesday, 4. November 2009 14:12:09 Levesque, Patrick wrote: >> > I have tried to support a TrippLite Internet350SER UPS using a serial >> > cable (The only connection on this model) using the 2.4 code branch. ?It >> > uses the Protocol 1004 from the tripplite specification that can be use >> > either used on serial or USB device. ?Since my device was only serial, I >> > worked only on the serial integration. ?Since I found nothing in >> > tripplite.c, tripplite-hid.c, tripplitesu.c to support my model, I have >> > done trippliteser.c in order to support my unit. ?Not all the >> > functionality are there but the core functionality is there. ?Since it >> > is licence as GPLv2, I just want to push back my modifs to the community >> > but really don't know the procedure. >> >> Do you know how diff/patch works? Just send your changes >> as unified diff (diff -u) to the devel list. Might be a good >> idea to prefix your mail subject with "[PATCH]". >> >> If possible, try to prevent winmail.dat attachments on the mailing list, >> so people with a normal email client can open the attachment. >> >> Cheers, >> Thomas
Hi Patrick, first, please keep the traffic on the list... 2009/11/9 Levesque, Patrick:> The protocol is supposed to fit USB and serial devices but unfortunately, my unit only got the serial port.this is indeed what I inferred from a quick reading.> ?As for integrating the team, I don't have a lot of spare time but yes, if I can help, I'll do it.this one was directed to Thomas, who has handled the interface with you... cheers, Arnaud -- Linux / Unix Expert R&D - Eaton - http://www.eaton.com/mgeops Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://www.debian.org Free Software Developer - http://arnaud.quette.free.fr/> -----Original Message----- > From: Arnaud Quette > Sent: Monday, November 09, 2009 7:48 AM > To: Thomas Jarosch; Charles Lepple > Cc: nut-upsdev at lists.alioth.debian.org; Levesque, Patrick > Subject: Re: [Nut-upsdev] [PATCH] New to nut project > > Hi Thomas, > > thanks for interfacing with Patrick on this point. > btw, would you be interested in integrating the team? > > I'll leave up to Charles to check the patch. > I don't know much about Tripplite protocols, but this one seems to be > a variation of the existing ones (1001 and 3003, so maybe a 4004?!), > which means that it could possibly be merged in the existing tripplite > drivers. > All in all, Charles will hopefully have comments... > > @Patrick: do you have a USB port too, or only a serial one? > > cheers, > Arnaud > -- > Linux / Unix Expert R&D - Eaton - http://www.eaton.com/mgeops > Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ > Debian Developer - http://www.debian.org > Free Software Developer - http://arnaud.quette.free.fr/ > > > 2009/11/9 Thomas Jarosch: >> ---------- ?Forwarded Message ?---------- >> >> Subject: [PATCH] New to nut project >> Date: Friday, 6. November 2009 >> From: Patrick Levesque >> To: Thomas Jarosch >> >> As requested, here is my patch file including all my modification to the >> 2.4.1 >> tarball from the web site. >> >> On Friday 06 November 2009 05:41:29 you wrote: >>> Hello Patrick, >>> >>> On Wednesday, 4. November 2009 14:12:09 Levesque, Patrick wrote: >>> > I have tried to support a TrippLite Internet350SER UPS using a serial >>> > cable (The only connection on this model) using the 2.4 code branch. ?It >>> > uses the Protocol 1004 from the tripplite specification that can be use >>> > either used on serial or USB device. ?Since my device was only serial, I >>> > worked only on the serial integration. ?Since I found nothing in >>> > tripplite.c, tripplite-hid.c, tripplitesu.c to support my model, I have >>> > done trippliteser.c in order to support my unit. ?Not all the >>> > functionality are there but the core functionality is there. ?Since it >>> > is licence as GPLv2, I just want to push back my modifs to the community >>> > but really don't know the procedure. >>> >>> Do you know how diff/patch works? Just send your changes >>> as unified diff (diff -u) to the devel list. Might be a good >>> idea to prefix your mail subject with "[PATCH]". >>> >>> If possible, try to prevent winmail.dat attachments on the mailing list, >>> so people with a normal email client can open the attachment. >>> >>> Cheers, >>> Thomas > > This electronic message may contain proprietary and confidential information of Verint Systems Inc., its affiliates and/or subsidiaries. > The information is intended to be for the use of the individual(s) or > entity(ies) named above. ?If you are not the intended recipient (or authorized to receive this e-mail for the intended recipient), you may not use, copy, disclose or distribute to anyone this message or any information contained in this message. ?If you have received this electronic message in error, please notify us by replying to this e-mail. > >