Nut upsdev - Oct 2009 - Suspicious strcasecmp()

In drivers/snmp-ups.c:

                if (strcasecmp(cmdname, "shutdown.return")) {
                        ret = su_setvar("ups.delay.start", extradata);
                }
                if (strcasecmp(cmdname, "shutdown.stayoff")) {
                        ret = su_setvar("ups.delay.shutdown",
extradata);
                }
                if (strcasecmp(cmdname, "shutdown.reboot")) {
                        ret = su_setvar("ups.delay.reboot",
extradata);
                }

I think return value of strcasecmp() should be negated.

Gabor

Citeren "Kiss Gabor (Bitman)" <kissg op ssg.ki.iif.hu>:
> In drivers/snmp-ups.c:
>
>                 if (strcasecmp(cmdname, "shutdown.return")) {
>                         ret = su_setvar("ups.delay.start",
extradata);
>                 }
>                 if (strcasecmp(cmdname, "shutdown.stayoff")) {
>                         ret = su_setvar("ups.delay.shutdown",
extradata);
>                 }
>                 if (strcasecmp(cmdname, "shutdown.reboot")) {
>                         ret = su_setvar("ups.delay.reboot",
extradata);
>                 }
>
> I think return value of strcasecmp() should be negated.
Good catch!

This was an unfinished attempt to add these shutdown.* commands to the  
driver, but was never really tested. I removed the lot, stalling this  
until I both have the time and hardware to properly test this.

Best regards, Arjen
-- 
Please keep list traffic on the list