Charles Lepple
2007-Dec-30 14:48 UTC
[Nut-upsdev] eliminating GNU Make features in include/Makefile.am
I just noticed this warning from the autoreconf portion of the buildbot log: autoreconf: running: automake --no-force include/Makefile.am:9: shell unset LANG && svnversion -n $(top_srcdir: non-POSIX variable name include/Makefile.am:9: (probably a GNU make extension) include/Makefile.am:10: shell if test "$(SVNREV: non-POSIX variable name include/Makefile.am:10: (probably a GNU make extension) I think that the $(shell ...) construct is actually a GNU Make feature. Since we do not use the variables on lines 9 and 10 outside the nut_version.h rule below, does anyone have any objections to merging those shell commands into that rule? I would also like to add some code to gracefully handle the case where svnversion does not exist on the target system, which is related, but still can cause a problem on systems with GNU Make. (This is what creates version numbers like "2.2.0-", with the trailing hyphen.) -- - Charles Lepple
Arnaud Quette
2007-Dec-31 08:52 UTC
[Nut-upsdev] eliminating GNU Make features in include/Makefile.am
Hey Charles, 2007/12/30, Charles Lepple <clepple at gmail.com>:> I just noticed this warning from the autoreconf portion of the buildbot log: > > autoreconf: running: automake --no-force > include/Makefile.am:9: shell unset LANG && svnversion -n $(top_srcdir: > non-POSIX variable name > include/Makefile.am:9: (probably a GNU make extension) > include/Makefile.am:10: shell if test "$(SVNREV: non-POSIX variable name > include/Makefile.am:10: (probably a GNU make extension) > > I think that the $(shell ...) construct is actually a GNU Make feature. > > Since we do not use the variables on lines 9 and 10 outside the > nut_version.h rule below, does anyone have any objections to merging > those shell commands into that rule? > > I would also like to add some code to gracefully handle the case where > svnversion does not exist on the target system, which is related, but > still can cause a problem on systems with GNU Make. (This is what > creates version numbers like "2.2.0-", with the trailing hyphen.)perfect. I've never got time to get back on this and find a more suitable solution than the big hack that solves the versioning problem (previously, a source built on a non C locale system resulted in a "2.2.0-" version number...) Arnaud -- Linux / Unix Expert R&D - MGE Office Protection Systems - http://www.mgeops.com Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://people.debian.org/~aquette/ Free Software Developer - http://arnaud.quette.free.fr/
Apparently Analagous Threads
- Makefile fix for tarball compilation
- [nut-commits] svn commit r1207 - in trunk: . include
- revisiting #613643 - Should include/nut_version.h be removed from nut_2.4.3.orig.tar.gz?
- Patch -- SVN revision in the version string
- Storage of byte code-compiled functions in sysdata.rda