Nut upsdev - Jan 2007 - Re: [nut-commits] svn commit r746 - trunk/packaging/RedHat

With automake, we collectively need to check to see if 'make
distcheck' still works after adding or removing files. Basically,
nothing will make its way into the NUT distribution tarball unless it
is somehow mentioned in one of the Makefile.am files. See the
packaging/RedHat directory for an example.

Niels, thank you for spotting the extra nut.spec file in SVN; however,
it needs to be added to configure.in's AC_OUTPUT section in order to
be generated from nut.spec.in. I will commit that change shortly. Can
you test the generated file? If it works, we'll assume the same change
works for mandriva.

On 1/16/07, Niels Baggesen <nba-guest@alioth.debian.org>
wrote:
> Author: nba-guest
> Date: Tue Jan 16 19:31:39 2007
> New Revision: 746
>
> Removed:
>    trunk/packaging/RedHat/nut.spec
> Log:
>
>
> _______________________________________________
> nut-commits mailing list
> nut-commits@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/nut-commits
>

-- 
- Charles Lepple

Charles Lepple wrote:
> 
> With automake, we collectively need to check to see if 'make
> distcheck' still works after adding or removing files. Basically,
> nothing will make its way into the NUT distribution tarball unless it
> is somehow mentioned in one of the Makefile.am files. See the
> packaging/RedHat directory for an example.
I would like to support Charles's point. "make distcheck" is your
friend. It should be our informal policy that any trunk revision
should pass "make distcheck" before it is committed. This will be
important when we generate daily tarballs, a feature that can be
expected in the near future.

I realize that "make distcheck" is not working for all developers.  It
fails if you don't have all requisite libraries installed (libssl,
libnetsnmp, libusb, libhal, libgd, ...). On some platforms, it is not
even possible to install all of these. 

For this reason, I now have created a new target:

   make distcheck-light

This will check all of the features that your installation supports.
It is a reasonable pre-commit test for most people. Before creating
any actual distribution, someone should still run the full "make
distcheck".

Alternatively, we could run teach SVN to "make distcheck" on Alioth in
a pre-commit script, refusing to commit anything that does not
pass. But this would be draconian at this point, and would slow down
commits by several minutes.

-- Peter

On Tue, Jan 16, 2007 at 08:51:42PM -0500, Charles Lepple
wrote:
> With automake, we collectively need to check to see if 'make
> distcheck' still works after adding or removing files. Basically,
> nothing will make its way into the NUT distribution tarball unless it
> is somehow mentioned in one of the Makefile.am files. See the
> packaging/RedHat directory for an example.
My bad, I didn't know about distcheck. Is it documented anywhere?
> Niels, thank you for spotting the extra nut.spec file in SVN; however,
> it needs to be added to configure.in's AC_OUTPUT section in order to
> be generated from nut.spec.in. I will commit that change shortly. Can
> you test the generated file? If it works, we'll assume the same change
> works for mandriva.
Thanks, I must have missed it when checking my svn diff.

There are some further inconsistencies in the nut.spec that I will have
to rule out shortly as I am deploying the rpm internally.

/Niels

-- 
Niels Baggesen -- @home -- ?rhus -- Denmark -- niels@baggesen.net
The purpose of computing is insight, not numbers  --  R W Hamming

On 1/17/07, Niels Baggesen <niels@baggesen.net>
wrote:
> On Tue, Jan 16, 2007 at 08:51:42PM -0500, Charles Lepple wrote:
> > With automake, we collectively need to check to see if 'make
> > distcheck' still works after adding or removing files. Basically,
> > nothing will make its way into the NUT distribution tarball unless it
> > is somehow mentioned in one of the Makefile.am files. See the
> > packaging/RedHat directory for an example.
>
> My bad, I didn't know about distcheck. Is it documented anywhere?
Peter has mentioned it a few times on the list and in the ChangeLog,
but I don't think we mention it in the docs directory.
> > Niels, thank you for spotting the extra nut.spec file in SVN; however,
> > it needs to be added to configure.in's AC_OUTPUT section in order
to
> > be generated from nut.spec.in. I will commit that change shortly. Can
> > you test the generated file? If it works, we'll assume the same
change
> > works for mandriva.
>
> Thanks, I must have missed it when checking my svn diff.
>
> There are some further inconsistencies in the nut.spec that I will have
> to rule out shortly as I am deploying the rpm internally.
OK, sounds good.

-- 
- Charles Lepple