Nut upsdev - Dec 2006 - Re: [nut-commits] svn commit r609 - trunk

Charles Lepple wrote:
> 
> Author: clepple-guest
> Date: Mon Dec  4 03:00:57 2006
> New Revision: 609
> 
> Modified:
>    trunk/ChangeLog
>    trunk/configure.in
> Log:
> Undoing changeset [608]. It fails with this error:
> 
>    configure: error: conditional "HAVE_LIBUSB" was never defined.
>    Usually this means the macro was only invoked conditionally.
> 
> if --with-usb is not passed. Not sure why; the HIDDEV macro is defined
> conditionally, and I definitely don't have hiddev on OS X. I will
revisit this
> when I am more awake.
This just means that the following two lines:

AM_CONDITIONAL(HAVE_LIBUSB, test "${nut_have_libusb}" =
"yes")
AM_CONDITIONAL(HAVE_HIDDEV, test -n "${linux_hiddev}")

are not allowed to appear inside "if ... fi". This makes sense, as
automake-conditionals have to be defined regardless. You have to move
these lines to after the section you "conditioned out".

-- Peter

On 12/3/06, Peter Selinger <selinger@mathstat.dal.ca>
wrote:
> Charles Lepple wrote:
> > Log:
> > Undoing changeset [608]. It fails with this error:
> >
> >    configure: error: conditional "HAVE_LIBUSB" was never
defined.
> >    Usually this means the macro was only invoked conditionally.
> >
> > if --with-usb is not passed. Not sure why; the HIDDEV macro is defined
> > conditionally, and I definitely don't have hiddev on OS X. I will
revisit this
> > when I am more awake.
>
> This just means that the following two lines:
>
> AM_CONDITIONAL(HAVE_LIBUSB, test "${nut_have_libusb}" =
"yes")
> AM_CONDITIONAL(HAVE_HIDDEV, test -n "${linux_hiddev}")
>
> are not allowed to appear inside "if ... fi". This makes sense,
as
> automake-conditionals have to be defined regardless. You have to move
> these lines to after the section you "conditioned out".
oh, OK. I saw this inside an "if" statement:
"AC_DEFINE_UNQUOTED(LINUX_HIDDEV...)" and confused that with
AM_CONDITIONAL.

-- 
- Charles Lepple