Kirill Smelkov
2005-Sep-19 12:54 UTC
[Nut-upsdev] [resend] [patch] driver for Eltek AL175 alarm module
Hello up there! Attached is my patch to add support for AL175 alarm module, Please ACK or NAK this. -- ?????? ??????? -------------- next part -------------- A non-text attachment was scrubbed... Name: al175.patch Type: text/x-diff Size: 35632 bytes Desc: not available Url : http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20050919/84b639e0/al175-0001.bin
Arnaud Quette
2005-Sep-20 14:27 UTC
[Nut-upsdev] Re: [resend] [patch] driver for Eltek AL175 alarm module
Hi Kirill, Attached is my patch to add support for AL175 alarm module,> Please ACK or NAK this. > >there are some things that need to be reworked: * variables: (see http://eu1.networkupstools.org/doc/2.0.1/new-names.html) all the below vars are non standard. what do you put in all of these? thanks to detail back, as in new names. - load.fuse - battery.fuse - symalarm.fuse - battery.contactor - load.contactor - lvd.contactor * load.current: this var doesn't exist! If it's the output current, then the right var is output.current. <http://driver.name> * driver.name <http://driver.name> is already published by the core (main.c), so you can remove it. * you should use the internal xmalloc() function * please send your diff in unified format (diff -Nru orig.tree modified.tree ) * the driver's manpage is missing (al175.8) More generally, please read the following to ensure you comply with NUT standard for coding, variables names, ... : http://eu1.networkupstools.org/doc/2.0.1/developers.html http://eu1.networkupstools.org/doc/2.0.1/new-drivers.html http://eu1.networkupstools.org/doc/2.0.1/new-names.html Please, correct the above, and discuss on upsdev the variables problem... Thanks for your contribution, Arnaud -- Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://people.debian.org/~aquette/<http://people.debian.org/%7Eaquette/> OpenSource Developer - http://arnaud.quette.free.fr/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20050920/2425e1d9/attachment.htm
Arnaud Quette
2005-Oct-08 21:42 UTC
[Nut-upsdev] Re: [resend] Re: [resend] [patch] driver for Eltek AL175 alarm module
Hi Kirill, sorry for the long delay in answering... I've merged, in the CVS development tree, a modified version of your driver. What I've done: - created al175.h for consistency - disabled (not removed) non conformant vars and status - remove the "goto". - modified man/Makefile.in Please test it, and ack back. some more info below... 2005/9/28, Kirill Smelkov <kirr@mns.spb.ru>:> > Hello up there! > > This is my 2nd try. > Please ACK or NAK this. > > --- on 21-SEP-2005 I wrote --- > Hi Arnaud, > Thank you for your reply! > > ... > > * you should use the internal xmalloc() function > done. do you have any objections againts raw_alloca?none, just advices ;-) ...> > More generally, please read the following to ensure you comply with NUT > > standard for coding, variables names, ... : > > http://eu1.networkupstools.org/doc/2.0.1/developers.html > > http://eu1.networkupstools.org/doc/2.0.1/new-drivers.html > > http://eu1.networkupstools.org/doc/2.0.1/new-names.html > Ugh... > I changed some things, like sprintf -> snprintf, exit -> fatal, etc... > Is it ok now?yes, fine thanks. there are still things left, like: - DEBUG should be removed: have a look at mge-shut.c/dump_hex() More generally, have a look at upslogx and upsdebugx possibilities. These allows runtime tracing, for logging (into syslog and alike) or debugging, without the need to recompile. - indent: http://eu1.networkupstools.org/doc/2.0.1/developers.html Use tab please! - alarm_handler()!> Please, correct the above, and discuss on upsdev the variables problem... > As to new variables: > Is it possible to comment or not include at all code that sets them?that's what I've done. So you still have these for further use I hope I've not forgotten anything, but I don't make promise ;-) Thanks again, Arnaud -- Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://people.debian.org/~aquette/<http://people.debian.org/%7Eaquette/> OpenSource Developer - http://arnaud.quette.free.fr/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20051008/4a63264b/attachment.html
Kirill Smelkov
2005-Oct-10 05:48 UTC
[Nut-upsdev] Re: [resend] Re: [resend] [patch] driver for Eltek
9 ??????? 2005 21:43, Peter Selinger ???????:> Kirill Smelkov wrote: > > 2. new status: HB = High Battery > > There should be no such status flag as "High Battery". NUT simply uses > the absence of "LB" to indicate this state.Ok, maybe you are right. Although in my ups there are 3 states: LB -- low battery HB -- high battery ?? -- normal battery (?? = NB) Maybe it is worth extending status semantic? -- ????? ????????, ??????.