Danilo Krummrich
2024-Feb-19 09:32 UTC
[PATCH 1/2] drm/nouveau: don't fini scheduler if not initialized
On 2/15/24 00:48, Timur Tabi wrote:> On Fri, 2024-02-02 at 17:14 +0000, Timur Tabi wrote: >> On Fri, 2024-02-02 at 01:05 +0100, Danilo Krummrich wrote: >>> nouveau_abi16_ioctl_channel_alloc() and nouveau_cli_init() simply call >>> their corresponding *_fini() counterpart. This can lead to >>> nouveau_sched_fini() being called without struct nouveau_sched ever >>> being initialized in the first place. >> >> Thanks, I've confirmed that these patches do fix the problem. > > Looks like I spoke too soon, I just hit the problem with the drm-next tree.Did you apply the patch to drm-next?> > I'm able to repro the problem by having r535_gsp_init() return an error. > r535_gsp_rpc_poll return -EINVAL (I'm testing my own GSP-RM build) and > nouveau_sched_fini() is called even though nouveau_sched_init() was never > called.
Timur Tabi
2024-Feb-20 19:45 UTC
[PATCH 1/2] drm/nouveau: don't fini scheduler if not initialized
On Mon, 2024-02-19 at 10:32 +0100, Danilo Krummrich wrote: Looks like I spoke too soon, I just hit the problem with the drm-next tree. Did you apply the patch to drm-next? Ugh, you're right. I don't how I got confused, but I could have sworn that I saw your two patches in drm-next, but they are not there. Sorry for the noise. -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20240220/2bac9893/attachment.htm>