Randy Dunlap
2023-Oct-07 00:55 UTC
[Nouveau] [PATCH] drm/nouveau: exec: fix ioctl kernel-doc warning
include/uapi/drm/nouveau_drm.h:49: warning: Cannot understand * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX on line 49 - I thought it was a doc line Fixes: d59e75eef52d ("drm/nouveau: exec: report max pushs through getparam") Signed-off-by: Randy Dunlap <rdunlap at infradead.org> Cc: Dave Airlie <airlied at redhat.com> Cc: Danilo Krummrich <dakr at redhat.com> Cc: Karol Herbst <kherbst at redhat.com> Cc: Lyude Paul <lyude at redhat.com> Cc: dri-devel at lists.freedesktop.org Cc: nouveau at lists.freedesktop.org --- include/uapi/drm/nouveau_drm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/include/uapi/drm/nouveau_drm.h b/include/uapi/drm/nouveau_drm.h --- a/include/uapi/drm/nouveau_drm.h +++ b/include/uapi/drm/nouveau_drm.h @@ -45,8 +45,8 @@ extern "C" { #define NOUVEAU_GETPARAM_HAS_BO_USAGE 15 #define NOUVEAU_GETPARAM_HAS_PAGEFLIP 16 -/** - * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX +/* + * NOUVEAU_GETPARAM_EXEC_PUSH_MAX - query max pushes through getparam * * Query the maximum amount of IBs that can be pushed through a single * &drm_nouveau_exec structure and hence a single &DRM_IOCTL_NOUVEAU_EXEC
Lyude Paul
2023-Oct-09 21:47 UTC
[Nouveau] [PATCH] drm/nouveau: exec: fix ioctl kernel-doc warning
Reviewed-by: Lyude Paul <lyude at redhat.com> On Fri, 2023-10-06 at 17:55 -0700, Randy Dunlap wrote:> include/uapi/drm/nouveau_drm.h:49: warning: Cannot understand * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX > on line 49 - I thought it was a doc line > > Fixes: d59e75eef52d ("drm/nouveau: exec: report max pushs through getparam") > Signed-off-by: Randy Dunlap <rdunlap at infradead.org> > Cc: Dave Airlie <airlied at redhat.com> > Cc: Danilo Krummrich <dakr at redhat.com> > Cc: Karol Herbst <kherbst at redhat.com> > Cc: Lyude Paul <lyude at redhat.com> > Cc: dri-devel at lists.freedesktop.org > Cc: nouveau at lists.freedesktop.org > --- > include/uapi/drm/nouveau_drm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff -- a/include/uapi/drm/nouveau_drm.h b/include/uapi/drm/nouveau_drm.h > --- a/include/uapi/drm/nouveau_drm.h > +++ b/include/uapi/drm/nouveau_drm.h > @@ -45,8 +45,8 @@ extern "C" { > #define NOUVEAU_GETPARAM_HAS_BO_USAGE 15 > #define NOUVEAU_GETPARAM_HAS_PAGEFLIP 16 > > -/** > - * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX > +/* > + * NOUVEAU_GETPARAM_EXEC_PUSH_MAX - query max pushes through getparam > * > * Query the maximum amount of IBs that can be pushed through a single > * &drm_nouveau_exec structure and hence a single &DRM_IOCTL_NOUVEAU_EXEC >-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat