Thierry Reding
2020-Jun-03 14:20 UTC
[Nouveau] [PATCH] drm/nouveau: gr/gk20a: Use firmware version 0
From: Thierry Reding <treding at nvidia.com> Tegra firmware doesn't actually use any version numbers and passing -1 causes the existing firmware binaries not to be found. Use version 0 to find the correct files. Signed-off-by: Thierry Reding <treding at nvidia.com> --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c index ec330d791d15..e56880f3e3bd 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c @@ -352,7 +352,7 @@ gk20a_gr_load(struct gf100_gr *gr, int ver, const struct gf100_gr_fwif *fwif) static const struct gf100_gr_fwif gk20a_gr_fwif[] = { - { -1, gk20a_gr_load, &gk20a_gr }, + { 0, gk20a_gr_load, &gk20a_gr }, {} }; -- 2.24.1
Emil Velikov
2020-Jun-03 15:39 UTC
[Nouveau] [PATCH] drm/nouveau: gr/gk20a: Use firmware version 0
On Wed, 3 Jun 2020 at 15:20, Thierry Reding <thierry.reding at gmail.com> wrote:> > From: Thierry Reding <treding at nvidia.com> > > Tegra firmware doesn't actually use any version numbers and passing -1 > causes the existing firmware binaries not to be found. Use version 0 to > find the correct files. > > Signed-off-by: Thierry Reding <treding at nvidia.com>Fixes: ef16dc278ec2 ("drm/nouveau/gr/gf100-: select implementation based on available FW") Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com> -Emil
Ben Skeggs
2020-Jun-03 19:50 UTC
[Nouveau] [PATCH] drm/nouveau: gr/gk20a: Use firmware version 0
On Thu, 4 Jun 2020 at 01:43, Emil Velikov <emil.l.velikov at gmail.com> wrote:> > On Wed, 3 Jun 2020 at 15:20, Thierry Reding <thierry.reding at gmail.com> wrote: > > > > From: Thierry Reding <treding at nvidia.com> > > > > Tegra firmware doesn't actually use any version numbers and passing -1 > > causes the existing firmware binaries not to be found. Use version 0 to > > find the correct files. > > > > Signed-off-by: Thierry Reding <treding at nvidia.com> > > Fixes: ef16dc278ec2 ("drm/nouveau/gr/gf100-: select implementation > based on available FW") > Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>Oops, my bad. Merged. Ben.> > -Emil > _______________________________________________ > Nouveau mailing list > Nouveau at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau
Seemingly Similar Threads
- [PATCH AUTOSEL 5.7 090/388] drm/nouveau: gr/gk20a: Use firmware version 0
- [PATCH] drm/nouveau: gr/gk20a: Use firmware version 0
- [PATCH] drm/nouveau: Fixup gk20a instobj hierarchy
- [PATCH] drm/nouveau: gk20a: Turn instmem lock into mutex
- [PATCH] drm/nouveau: gk20a: Turn instmem lock into mutex